Skip to content

Commit 8dd9f2f

Browse files
authored
Merge pull request #85 from buildkite/fix_ghcr_login
fix: add GHCR login during release to push images
2 parents 5e6e1dd + e92002a commit 8dd9f2f

2 files changed

Lines changed: 16 additions & 0 deletions

File tree

.buildkite/pipeline.release.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ steps:
4141
- pipeline_slug
4242
- aws-ssm#v1.0.0:
4343
parameters:
44+
GITHUB_USER: /pipelines/buildkite/buildkite-mcp-server-release/github-user
4445
GITHUB_TOKEN: /pipelines/buildkite/buildkite-mcp-server-release/github-token
4546
DOCKERHUB_PASSWORD: /pipelines/buildkite/buildkite-mcp-server-release/dockerhub-password
4647
DOCKERHUB_USER: /pipelines/buildkite/buildkite-mcp-server-release/dockerhub-user
@@ -54,6 +55,7 @@ steps:
5455
- --merge
5556
config: .buildkite/docker-compose.yaml
5657
env:
58+
- GITHUB_USER
5759
- GITHUB_TOKEN
5860
- DOCKERHUB_USER
5961
- DOCKERHUB_PASSWORD

.buildkite/release.sh

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,20 @@ else
2222
fi
2323
fi
2424

25+
# check if GITHUB_USER is set
26+
if [[ -z "${GITHUB_USER:-}" ]]; then
27+
echo "Skipping GHCR login as GITHUB_USER is not set"
28+
else
29+
echo "--- :key: :github: Login to GHCR using ko"
30+
echo "$GITHUB_TOKEN" | ko login ghcr.io --username "$GITHUB_USER" --password-stdin
31+
if [[ $? -ne 0 ]]; then
32+
echo "GitHub login failed"
33+
exit 1
34+
fi
35+
fi
36+
37+
echo "--- :goreleaser: Building release with GoReleaser"
38+
2539
if [[ $? -ne 0 ]]; then
2640
echo "Failed to retrieve GoReleaser Pro key"
2741
exit 1

0 commit comments

Comments
 (0)