Merge pull request #72 from buildkite/toote_alphabetized_attrs

Alphabetized attrs

Author: toote

app/lib/bk/compat/pipeline/step.rb

@@ -47,13 +47,13 @@ def instantiate
 
     # basic command step
     class CommandStep
-      attr_accessor :agents, :concurrency, :concurrency_group, :conditional, :depends_on, :key, :label,
-                    :matrix, :parameters, :plugins, :soft_fail, :timeout_in_minutes, :transformer, :artifact_paths,
-                    :branches
+      attr_accessor :agents, :artifact_paths, :branches, :concurrency, :concurrency_group,
+                    :conditional, :depends_on, :key, :label, :matrix, :parameters, :plugins,
+                    :soft_fail, :timeout_in_minutes, :transformer
 
       attr_reader :commands, :env # we define special writers
 
-      LIST_ATTRIBUTES = %w[commands depends_on plugins artifact_paths].freeze
+      LIST_ATTRIBUTES = %w[artifact_paths commands depends_on plugins].freeze
       HASH_ATTRIBUTES = %w[agents env matrix parameters].freeze
 
       def initialize(**kwargs)

app/spec/lib/bk/compat/__snapshots__/examples/github-actions/django-ci-test.yaml.snap

@@ -1,6 +1,10 @@
 ---
 steps:
-- commands:
+- artifact_paths:
+  - vendor/output/bin/**/*
+  - vendor/output/test-results
+  - vendor2/output/bin/*.log
+  commands:
   - "# action actions/checkout@v2 is not necessary in Buildkite"
   - echo '~~~ Install requirements'
   - pip install -r requirements.txt
@@ -10,10 +14,6 @@ steps:
   plugins:
   - docker#v5.7.0:
       image: python:3.8
-  artifact_paths:
-  - vendor/output/bin/**/*
-  - vendor/output/test-results
-  - vendor2/output/bin/*.log
   agents:
     runs-on: ubuntu-latest
   label: ":github: simple_build"

app/spec/lib/bk/compat/__snapshots__/examples/github-actions/laravel-tests.yml.snap

@@ -1,6 +1,8 @@
 ---
 steps:
-- commands:
+- artifact_paths:
+  - vendor/orchestra/testbench-core/laravel/storage/logs
+  commands:
   - "# It may be a good idea to use docker compose to start up job-specific services"
   - echo 'Starting memcached service'
   - docker start --rm -d --name memcached --expose '11211:11211' memcached:1.6-alpine
@@ -30,8 +32,6 @@ steps:
   - vendor/bin/phpunit --display-deprecation
   - )
   - docker stop memcached mysql redis dynamodb
-  artifact_paths:
-  - vendor/orchestra/testbench-core/laravel/storage/logs
   agents:
     runs-on: ubuntu-22.04
   matrix: