Skip to content

Commit 23a6473

Browse files
authored
Merge pull request #979 from buildo/fix-readonly-field
Fix ReadOnlyField's copy functionality
2 parents e8f7645 + d962388 commit 23a6473

File tree

1 file changed

+18
-10
lines changed

1 file changed

+18
-10
lines changed

packages/bento-design-system/src/ReadOnlyField/ReadOnlyField.tsx

+18-10
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,18 @@ type Props = Omit<
1212
"onChange" | "onBlur" | "disabled" | "isReadOnly" | "placeholder" | "issues"
1313
> &
1414
(
15-
| {
15+
| ({
1616
withCopyButton: true;
1717
copyButtonLabel: LocalizedString;
18-
copySuccessMessage: LocalizedString;
19-
showToastOnCopy?: boolean;
20-
}
18+
} & (
19+
| {
20+
copySuccessMessage: LocalizedString;
21+
showToastOnCopy: true;
22+
}
23+
| {
24+
showToastOnCopy?: false;
25+
}
26+
))
2127
| {
2228
withCopyButton?: false;
2329
}
@@ -36,14 +42,16 @@ export function ReadOnlyField(props: Props) {
3642
<IconButton
3743
icon={config.copyIcon}
3844
onPress={async () => {
39-
if (props.showToastOnCopy ?? true) {
45+
if (props.withCopyButton) {
4046
try {
4147
await navigator.clipboard.writeText(props.value);
42-
showToast({
43-
kind: "informative",
44-
message: props.copySuccessMessage,
45-
dismissable: true,
46-
});
48+
if (props.showToastOnCopy) {
49+
showToast({
50+
kind: "informative",
51+
message: props.copySuccessMessage,
52+
dismissable: true,
53+
});
54+
}
4755
} catch {
4856
console.error("Could not copy to clipboard");
4957
}

0 commit comments

Comments
 (0)