Skip to content

Commit 99a44a7

Browse files
Merge pull request #824 from buildo/disable_select_autoopenonfocus
Allow control of Select open-on-focus behavior
2 parents fd1c215 + 074f156 commit 99a44a7

File tree

4 files changed

+4
-1
lines changed

4 files changed

+4
-1
lines changed

packages/bento-design-system/src/SelectField/BaseSelect.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ export function BaseSelect<A>(props: Props<A>) {
107107
placeholder={placeholder}
108108
menuPortalTarget={menuPortalTarget.current}
109109
components={selectComponents}
110-
openMenuOnFocus
110+
openMenuOnFocus={props.openMenuOnFocus ?? dropdownConfig.openMenuOnFocus}
111111
styles={selectComponents.styles<SelectOption<A>>()}
112112
validationState={validationState}
113113
isMulti={isMulti}

packages/bento-design-system/src/SelectField/Config.ts

+1
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,5 @@ export type DropdownConfig = {
1616
openIndicatorIconSize: IconProps["size"];
1717
chipColor: ChipProps["color"];
1818
chipSpacing: BentoSprinkles["gap"];
19+
openMenuOnFocus: boolean;
1920
};

packages/bento-design-system/src/SelectField/types.ts

+1
Original file line numberDiff line numberDiff line change
@@ -38,4 +38,5 @@ export type BaseSelectProps<A> = {
3838
noOptionsMessage?: LocalizedString;
3939
isReadOnly?: boolean;
4040
searchable?: boolean;
41+
openMenuOnFocus?: boolean;
4142
};

packages/bento-design-system/src/util/defaultConfigs.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -499,6 +499,7 @@ export const dropdown: DropdownConfig = {
499499
openIndicatorIconSize: 24,
500500
chipColor: "indigo",
501501
chipSpacing: 4,
502+
openMenuOnFocus: true,
502503
};
503504

504505
export const table: TableConfig = {

0 commit comments

Comments
 (0)