Skip to content

Bug: SearchBar should not inherit all the Config properties from Input  #571

Open
@veej

Description

@veej

Description of the bug

SearchBar is currently inheriting all the Config properties from Input, omitting only the iconSize and adding a few other specific config keys: https://github.com/buildo/bento-design-system/blob/main/packages/bento-design-system/src/SearchBar/Config.ts#L5.

However, we added a few config options to Input that make sense only for the Input and not for the SearchBar (e.g. passwordShowIcon/passwordHideIcon/passwordIconSize). It might be better to cherry-pick the properties instead of omitting, or define a common baseConfig.

Playroom reproduction

No response

Version

v0.17.2

What browsers are you seeing the problem on?

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions