Merge pull request #35 from siuvdlec/main

no-lib-imports preserve quotes

Author: gabro

src/rules/no-lib-imports.ts

@@ -20,28 +20,29 @@ export default createRule({
   create(context) {
     return {
       ImportDeclaration(node) {
-        const sourceValue = node.source.value?.toString();
-        if (sourceValue) {
-          const forbiddenImportPattern = /^fp-ts\/lib\//;
+        const sourceValue = node.source.raw;
+        const openQuote = /^['"]{1}/;
+        const forbiddenImportPattern = /fp-ts\/lib\//;
 
+        if (
+          sourceValue.match(openQuote.source + forbiddenImportPattern.source)
+        ) {
           const fixedImportSource = sourceValue.replace(
             forbiddenImportPattern,
             "fp-ts/"
           );
 
-          if (sourceValue.match(forbiddenImportPattern)) {
-            context.report({
-              node: node.source,
-              messageId: "importNotAllowed",
-              data: {
-                detected: node.source.value,
-                fixed: fixedImportSource,
-              },
-              fix(fixer) {
-                return fixer.replaceText(node.source, `"${fixedImportSource}"`);
-              },
-            });
-          }
+          context.report({
+            node: node.source,
+            messageId: "importNotAllowed",
+            data: {
+              detected: node.source.value,
+              fixed: fixedImportSource,
+            },
+            fix(fixer) {
+              return fixer.replaceText(node.source, fixedImportSource);
+            },
+          });
         }
       },
     };

tests/rules/no-lib-imports.test.ts

@@ -11,7 +11,11 @@ const ruleTester = new ESLintUtils.RuleTester({
 ruleTester.run("no-lib-imports", rule, {
   valid: [
     'import { Option } from "fp-ts/Option"',
+    "import { Option } from 'fp-ts/Option'",
     'import { option } from "fp-ts"',
+    "import { option } from 'fp-ts'",
+    'import { option } from "library/fp-ts/lib"',
+    "import { option } from 'library/fp-ts/lib'",
   ],
   invalid: [
     {
@@ -23,5 +27,14 @@ ruleTester.run("no-lib-imports", rule, {
       ],
       output: 'import { Option } from "fp-ts/Option"',
     },
+    {
+      code: "import { Option } from 'fp-ts/lib/Option'",
+      errors: [
+        {
+          messageId: "importNotAllowed",
+        },
+      ],
+      output: "import { Option } from 'fp-ts/Option'",
+    },
   ],
 });