Skip to content

Commit 89a6a42

Browse files
committed
Fix bug with Popover (due to a typo in componentDidUpdate method name)
1 parent a6a8d93 commit 89a6a42

File tree

3 files changed

+9
-10
lines changed

3 files changed

+9
-10
lines changed

src/Menu/Examples.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
### Examples
22

33
```js
4-
intialState = { isOpen: false };
4+
const [state, setState] = React.useState({ isOpen: false });
55

66
function toggleOpen() {
77
setState({ isOpen: !state.isOpen });

src/Popover/Popover.tsx

+5-8
Original file line numberDiff line numberDiff line change
@@ -115,18 +115,15 @@ export class Popover extends React.Component<Popover.Props, State> {
115115
}
116116
}
117117

118-
componendDidUpdate() {
118+
componentDidUpdate(prevProps: Popover.Props) {
119119
this.updateDebouncedMousedEvents(this.props);
120120
this.saveValuesFromNodeTree();
121121

122-
const isOpenChanged = this.getPopoverProps().isOpen !== this.getPopoverProps(this.props).isOpen;
122+
const isOpenChanged = this.getPopoverProps(prevProps).isOpen !== this.getPopoverProps().isOpen;
123123

124124
if (!this.isStateful() && isOpenChanged) {
125125
this.onPopoverOpenChange(this.props);
126126
}
127-
}
128-
129-
componentDidUpdate() {
130127
if (this.containerNode && this.state.popover) {
131128
const popover = this.getVisiblePopover();
132129
const { context } = this.getPopoverProps();
@@ -215,13 +212,13 @@ export class Popover extends React.Component<Popover.Props, State> {
215212
onShow: () => {},
216213
onHide: () => {},
217214
onToggle: () => {},
218-
dismissOnClickOutside: true,
219-
dismissOnScroll: true,
220215
className: '',
221216
distance: 5,
222217
offsetX: 0,
223218
offsetY: 0,
224-
...props.popover
219+
...props.popover,
220+
dismissOnClickOutside: props.popover.dismissOnClickOutside !== false,
221+
dismissOnScroll: props.popover.dismissOnScroll !== false
225222
};
226223
};
227224

styleguide/StyleGuideRenderer.tsx

+3-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@ import * as brc from '../src';
33
import { getBackgroundUrl } from '../src/Image';
44
import OriginalStyleGuideRenderer from 'react-styleguidist/lib/client/rsg-components/StyleGuide/StyleGuideRenderer';
55

6-
export default class AStyleGuideRenderer extends React.Component {
6+
export default class AStyleGuideRenderer extends React.Component<
7+
React.ComponentProps<typeof OriginalStyleGuideRenderer>
8+
> {
79
componentDidMount() {
810
this.patchGlobal();
911
}

0 commit comments

Comments
 (0)