Skip to content

In 11-revoke-roles.js, it incorrectly revokes minting role for Governance/Vote contract #19

@Hampton-Black

Description

@Hampton-Black

I believe the recommended code in tutorial for 11-revoke-roles.js incorrectly revokes all minting roles, including the vote/governance contract.

Specifically, in this line:
await token.roles.setAll({ admin: [], minter: [] });

On my local end, I noticed both my personal wallet and the vote contract held minting roles in the 'before' section, and then all were revoked in the 'after' section.

Recommended fix would be to just specify the role to revoke. i.e.:

await token.roles.revoke("admin", process.env.WALLET_ADDRESS);
await token.roles.revoke("minter", process.env.WALLET_ADDRESS);

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions