Skip to content

Commit 0d8daa1

Browse files
donaldchaifalhassen
authored andcommitted
Make it an error to use placeholders of Composeables.
This method doesn't do anything, and not everyone is going to sift through build log spam to check whether the UI is going to break.
1 parent 371d103 commit 0d8daa1

File tree

1 file changed

+2
-3
lines changed
  • integration/compose/src/main/java/com/bumptech/glide/integration/compose

1 file changed

+2
-3
lines changed

integration/compose/src/main/java/com/bumptech/glide/integration/compose/GlideImage.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -329,9 +329,8 @@ public fun placeholder(painter: Painter?): Placeholder =
329329
* each time the load status changes. Do not use it in scrolling lists.
330330
*/
331331
@Deprecated(
332-
"Using this method forces recomposition when the image load state changes." +
333-
" If you require this behavior use GlideSubcomposition instead",
334-
level = DeprecationLevel.WARNING
332+
"This method doesn't do anything! Use GlideSubcomposition instead",
333+
level = DeprecationLevel.ERROR
335334
)
336335
@ExperimentalGlideComposeApi
337336
public fun placeholder(composable: @Composable () -> Unit): Placeholder =

0 commit comments

Comments
 (0)