Merge pull request #114 from bustle/bug/schedule-once

[Bug] Render multiple cards successfully

Author: lukemelia

.github/workflows/ci.yml

@@ -10,63 +10,42 @@ jobs:
   lint:
     name: Lint
     runs-on: ubuntu-latest
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-
-      - name: Setup Node.js
-        uses: actions/setup-node@v4
-        with:
-          node-version: '20'
-          cache: 'pnpm'
-
-      - name: Setup pnpm
-        uses: pnpm/action-setup@v2
-        with:
-          version: '10'
-
-      - name: Install dependencies
-        run: pnpm install --frozen-lockfile
 
-      - name: Run lint
-        run: pnpm run lint
-name: CI
-
-on:
-  push:
-    branches:
-      - main
-      - master
-  pull_request: {}
+    steps:
+      - uses: actions/checkout@v4
+      - uses: volta-cli/action@v4
+      - run: volta install node pnpm
+      - run: pnpm install --frozen-lockfile
+      - run: pnpm run lint
 
-jobs:
   test:
-    name: "Tests"
+    name: Tests
     runs-on: ubuntu-latest
+    needs: lint
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - uses: volta-cli/action@v4
       - run: volta install node pnpm
       - run: pnpm install --frozen-lockfile
-      - run: pnpm run lint
       - run: pnpm run test:ember
 
   floating:
-    name: "Floating Dependencies"
+    name: Floating Dependencies
     runs-on: ubuntu-latest
+    needs: lint
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - uses: volta-cli/action@v4
       - run: volta install node pnpm
       - run: pnpm install --no-lockfile
       - run: pnpm run test:ember
 
   try-scenarios:
-    name: ${{ matrix.try-scenario }}
+    name: Ember Try - ${{ matrix.try-scenario }}
     runs-on: ubuntu-latest
-    needs: "test"
+    needs: test
 
     strategy:
       fail-fast: false
@@ -79,7 +58,7 @@ jobs:
           - ember-canary
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - uses: volta-cli/action@v4
       - run: volta install node pnpm
       - run: pnpm install --frozen-lockfile

addon/components/render-mobiledoc.gts

@@ -1,6 +1,6 @@
 import Component from '@glimmer/component';
 import { tracked } from '@glimmer/tracking';
-import { scheduleOnce } from '@ember/runloop';
+import { schedule, scheduleOnce } from '@ember/runloop';
 import Renderer from 'ember-mobiledoc-dom-renderer';
 import { getDocument } from 'ember-mobiledoc-dom-renderer/utils/document';
 import { guidFor } from '@ember/object/internals';
@@ -324,7 +324,7 @@ export default class RenderMobiledocComponent extends Component<Signature> {
 
   private addCard(card: CardRegistration): void {
     // Defer mutation to after the current render to avoid updating a value during computation
-    scheduleOnce('afterRender', this, this._addCard, card);
+    schedule('afterRender', this, this._addCard, card);
   }
 
   private _addCard(card: CardRegistration): void {
@@ -333,7 +333,7 @@ export default class RenderMobiledocComponent extends Component<Signature> {
 
   private removeCard(card: CardRegistration): void {
     // Defer mutation to after the current render to avoid updating a value during computation
-    scheduleOnce('afterRender', this, this._removeCard, card);
+    schedule('afterRender', this, this._removeCard, card);
   }
 
   private _removeCard(card: CardRegistration): void {
@@ -344,7 +344,7 @@ export default class RenderMobiledocComponent extends Component<Signature> {
 
   private addAtom(atom: AtomRegistration): void {
     // Defer mutation to after the current render to avoid updating a value during computation
-    scheduleOnce('afterRender', this, this._addAtom, atom);
+    schedule('afterRender', this, this._addAtom, atom);
   }
 
   private _addAtom(atom: AtomRegistration): void {
@@ -353,7 +353,7 @@ export default class RenderMobiledocComponent extends Component<Signature> {
 
   private removeAtom(atom: AtomRegistration): void {
     // Defer mutation to after the current render to avoid updating a value during computation
-    scheduleOnce('afterRender', this, this._removeAtom, atom);
+    schedule('afterRender', this, this._removeAtom, atom);
   }
 
   private _removeAtom(atom: AtomRegistration): void {

package.json

@@ -58,6 +58,8 @@
     "@glint/environment-ember-template-imports": "^1.5.2",
     "@glint/template": "^1.6.2",
     "@release-it-plugins/lerna-changelog": "^8.0.1",
+    "@types/ember__application": "^4.0.11",
+    "@types/ember__runloop": "^4.0.10",
     "@typescript-eslint/eslint-plugin": "^8.46.2",
     "@typescript-eslint/parser": "^8.46.2",
     "broccoli-asset-rev": "^3.0.0",