Skip to content

Updated for running koans with Dart2#9

Open
ericomine wants to merge 18 commits into
butlermatt:masterfrom
ericomine:fix/dart2
Open

Updated for running koans with Dart2#9
ericomine wants to merge 18 commits into
butlermatt:masterfrom
ericomine:fix/dart2

Conversation

@ericomine
Copy link
Copy Markdown

From what I could see, these koans are the most referenced Dart koans online, but they were not updated to work with Dart2.

  • Replaced dart-sdk requirement to ^2.3.0
  • Replaced legacy unittest dep with test.
  • Most change in code due to change in testing API (isInstanceOf has been deprecated, using isA instead)

@butlermatt
Copy link
Copy Markdown
Owner

Hey thanks. I wasn't even aware this project was looked at in years.
Unfortunately I have a few different matters going on at just the moment, and it may take me a few days to go through this PR, but I did want to leave a note to let you know I've seen your PR and will hopefully be able to give a more thorough review in a few days. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants