@@ -584,57 +584,30 @@ available.
584584 should be a sibling to the ` AceTime ` repo:
585585 * ` $ cd ../date `
586586 * ` $ git pull `
587- * Verify that the ` AceTime ` library and the Hinnant ` date ` library agree with
588- each other using the same TZDB version. This requires going into the
589- [ AceTimeValidation] ( https://github.com/bxparks/AceTimeValidation ) project.
590- * BasicHinnantDateTest
591- * ` $ cd .../AceTimeValidation/BasicHinnantDateTest `
592- * Update the ` TZ_VERSION ` variable in the ` Makefile ` with the commit tag
593- of the new TZDB version. (e.g. ` TZ_VERSION = 2020c ` ).
594- * ` $ make clean `
595- * ` $ make `
596- * ` $ ./BasicHinnantDateTest.out | grep failed `
597- * There should be no failures.
598- * ExtendedHinnantDateTest
599- * ` $ cd .../AceTimeValidation/ExtendedHinnantDateTest `
600- * Update the ` TZ_VERSION ` variable in the ` Makefile ` with the commit tag
601- of the new TZDB version. (e.g. ` TZ_VERSION = 2020c ` ).
602- * ` $ make clean `
603- * ` $ make `
604- * ` $ ./ExtendedHinnantDateTest.out | grep failed `
605- * There should be no failures.
606587* Update the zonedb files for AceTimePython (needed by BasicAcetzTest and
607588 ExtendedAcetzTest):
608589 * ` $ cd AceTimePython/src/acetime/zonedb `
609- * Edit the ` Makefile ` and update the ` TZ_VERSION ` .
590+ * Update the ` TZ_VERSION ` variable in ` Makefile ` .
610591 * ` $ make `
611- * Verify that the ` AceTime ` library and the ` AceTimePython ` library agree with
612- each other using the same TZDB version. This requires going into the
613- [ AceTimeValidation] ( https://github.com/bxparks/AceTimeValidation ) project.
614- * BasicAcetzTest
615- * ` $ cd .../AceTimeValidation/BasicAcetzTest `
616- * Update the ` TZ_VERSION ` variable in the ` Makefile ` with the commit tag
617- of the new TZDB version. (e.g. ` TZ_VERSION = 2020c ` ).
618- * ` $ make clean `
619- * ` $ make `
620- * ` $ ./BasicAcetzTest.out | grep failed `
621- * There should be no failures.
622- * ExtendedAcetzTest
623- * ` $ cd .../AceTimeValidation/ExtendedAcetzTest `
624- * Update the ` TZ_VERSION ` variable in the ` Makefile ` with the commit tag
625- of the new TZDB version. (e.g. ` TZ_VERSION = 2020c ` ).
626- * ` $ make clean `
627- * ` $ make `
628- * ` $ ./ExtendedAcetzTest.out | grep failed `
629- * There should be no failures.
592+ * Verify that ` AceTimeValidation ` passes (which compares AceTime with
593+ AceTimePython and the Hinnant ` date ` library):
594+ * ` $ cd ../AceTimeValidation `
595+ * Update the ` TZ_VERSION ` variable in the following files:
596+ * ` BasicAcetzTest/Makefile `
597+ * ` ExtendedAcetzTest/Makefile `
598+ * ` BasicHinnantDateTest/Makefile `
599+ * ` ExtendedHinnantDateTest/Makefile `
600+ * ` $ make clean `
601+ * ` $ make validations `
602+ * ` $ make runvalidations `
630603* Update the various zoneinfo files for AceTime:
631604 * ` zonedb `
632- * ` $ cd src/ace_time/zonedb `
633- * Edit the ` Makefile ` and update the ` TZ_VERSION ` .
605+ * ` $ cd AceTime/ src/ace_time/zonedb `
606+ * Update the ` TZ_VERSION ` variable in ` Makefile ` .
634607 * ` $ make `
635608 * ` zonedbx `
636- * ` $ cd src/ace_time/zonedbx `
637- * Edit the ` Makefile ` and update the ` TZ_VERSION ` .
609+ * ` $ cd AceTime/ src/ace_time/zonedbx `
610+ * Update the ` TZ_VERSION ` variable in ` Makefile ` .
638611 * ` $ make `
639612* Update CHANGELOGs
640613 * AceTime/CHANGELOG.md
@@ -644,12 +617,26 @@ available.
644617 * ` $ git add ... `
645618 * ` $ git commit -m "..." `
646619
647- There are 6 other validation tests in the AceTimeValidation project that compare
648- AceTime with other third party libraries (Python pytz, Python dateutil, and Java
649- date). Unfortunately, they all seem to use the underlying TZDB version provided
650- by the Operating System, and I have not been able to figure out how to manually
651- update this dependency manually. When a new TZDB is released, all of these other
652- tests will fail until the underlying timezone database of the OS is updated.
620+ There are 12 other validation tests in the AceTimeValidation project that
621+ compare AceTime with various other third party libraries:
622+
623+ * ` BasicDateUtilTest `
624+ * ` BasicGoTest `
625+ * ` BasicJavaTest `
626+ * ` BasicNodaTest `
627+ * ` BasicPytzTest `
628+ * ` BasicZoneInfoTest `
629+ * ` ExtendedDateUtilTest `
630+ * ` ExtendedGoTest `
631+ * ` ExtendedJavaTest `
632+ * ` ExtendedNodaTest `
633+ * ` ExtendedPytzTest `
634+ * ` ExtendedZoneInfoTest `
635+
636+ Unfortunately, they all seem to use the underlying TZDB version provided by the
637+ Operating System, and I have not been able to figure out how to manually update
638+ this dependency manually. When a new TZDB is released, all of these tests will
639+ fail until the underlying timezone database of the OS is updated.
653640
654641<a name =" ReleaseProcess " ></a >
655642## Release Process
0 commit comments