Merge pull request davidherney#246 from davidherney/master

Fixed: davidherney#243. New subtopic visibility test.

Author: davidherney

lang/es/format_onetopic.php

@@ -136,7 +136,7 @@
 $string['tablabelhighlighted'] = 'Resaltada';
 $string['tablabelparent'] = 'Padre';
 $string['tabsectionbackground'] = 'Fondo del contenido de la sección';
-$string['tabsectionbackground_help'] = 'Se utiliza para cambiar el fondo del contenido de la sección. El valor puede ser un color en una representación válida de CSS, por ejemplo: <ul><li>Hexadecimal: #ffffff</li><li>RGB: rgb(0,255,0)</li><li>Nombre: verde</li></ul>
+$string['tabsectionbackground_help'] = 'Se utiliza para cambiar el fondo del contenido de la sección. El valor puede ser un color en una representación válida de CSS, por ejemplo: <ul><li>Hexadecimal: #ffffff</li><li>RGB: rgb(0,255,0)</li><li>Nombre: green</li></ul>
 También puede ser un atributo de URL y otras opciones de fondo de CSS.';
 $string['tabstylebuttons_help'] = 'Haga clic en cada botón para configurar la apariencia de la pestaña en cada uno de sus posibles estados.';
 $string['tabstyleclear'] = 'Borrar estilos';

lib.php

@@ -1203,9 +1203,14 @@ public function fot_get_sections_extra() {
      * @param string $availableinfo the 'availableinfo' propery of the section_info as it was evaluated by conditional availability.
      */
     public function section_get_available_hook(section_info $section, &$available, &$availableinfo) {
+        try {
+            $level = $section->level;
+        } catch (Exception $notused) {
+            return;
+        }
 
         // Only check childs tabs visibility.
-        if (!property_exists($section, 'level') || $section->level == 0) {
+        if (empty($level)) {
             return;
         }
 

tests/behat/subtopics_visibility.feature

@@ -0,0 +1,37 @@
+@format @format_onetopic
+Feature: Testing subtopics_visibility in format_onetopic
+  In order to keep subtopics aligned with their parents
+  As a student I should not see subtopics of hidden parent sections
+
+  Background:
+    Given the following "users" exist:
+      | username | firstname | lastname | email                |
+      | teacher1 | Teacher   | 1        | teacher1@example.com |
+      | student1 | Student   | 1        | student1@example.com |
+    And the following "courses" exist:
+      | fullname | shortname | format   | coursedisplay | numsections | hiddensections |
+      | Course 1 | C1        | onetopic | 0             | 5           | 1              |
+    And the following "course enrolments" exist:
+      | user     | course | role           |
+      | teacher1 | C1     | editingteacher |
+      | student1 | C1     | student        |
+    And I log in as "teacher1"
+
+  @javascript
+  Scenario: Subtopics of hidden parent sections are not visible to students
+    Given I am on "Course 1" course homepage with editing mode on
+    When I click on "Topic 2" "link" in the "#page-content ul.nav.nav-tabs" "css_element"
+    And I edit the section "2" and I fill the form with:
+      | Level | Child of previous tab |
+    And I click on "Topic 4" "link" in the "#page-content ul.nav.nav-tabs" "css_element"
+    And I edit the section "4" and I fill the form with:
+      | Level | Child of previous tab |
+    And I click on "Topic 3" "link" in the "#page-content ul.nav.nav-tabs" "css_element"
+    And I open section "3" edit menu
+    And I click on "Hide" "link"
+    And I log out
+    When I log in as "student1"
+    And I am on "Course 1" course homepage
+    And I click on "Topic 1" "link" in the "#page-content ul.nav.nav-tabs" "css_element"
+    Then I should see "Topic 2" in the "#page-content .onetopic-tab-body" "css_element"
+    And I should not see "Topic 4" in the "#page-content .onetopic-tab-body" "css_element"

version.php

@@ -33,7 +33,7 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$plugin->version = 2025021903; // The current plugin version (Date: YYYYMMDDXX).
+$plugin->version = 2025021903.01; // The current plugin version (Date: YYYYMMDDXX).
 $plugin->requires = 2025021400; // Requires this Moodle version.
 $plugin->component = 'format_onetopic'; // Full name of the plugin (used for diagnostics).
 $plugin->maturity = MATURITY_STABLE;