Changes after CR

Author: TobiGa

classes/header.php

@@ -391,12 +391,19 @@ private function get_tabs(course_modinfo $modinfo, \renderer_base $output): \for
                             // Apply the border to the tabs container when this specific tab is active.
                             // Only generate CSS if a background color is defined.
                             if (!empty($activebackgroundcolor) && ($type === 'active' || $type === 'default')) {
+                                // Add border bottom for horizontal tabs.
                                 $onecss .= '#tabs-tree-start:has(#onetabid-' . $thissection->id . ' a.nav-link.active) ';
                                 $onecss .= '.format_onetopic-tabs { ';
                                 $onecss .= 'border-bottom: 2px solid ' . $activebackgroundcolor . ' !important; ';
                                 $onecss .= 'padding-bottom: 1px; ';
                                 $onecss .= '} ';
-                                $onecss .= '#onetabid-' . $thissection->id . ' .nav-link.active { border-color: ' . $activebackgroundcolor . '; }';
+                                $onecss .= '#onetabid-' . $thissection->id . ' .nav-link.active { border-color: ' . $activebackgroundcolor . '; } ';
+                                // Deny border for parent tab.
+                                $onecss .= '#tabs-tree-start .tabs-wrapper .format_onetopic-tabs:has(#onetabid-' . $thissection->id . '.haschilds a.nav-link.active) ';
+                                $onecss .= '{ ';
+                                $onecss .= 'border-bottom: 2px solid lightgray !important; ';
+                                $onecss .= '} ';
+                                // Add border left for vertical tabs.
                                 $onecss .= '#tabs-tree-start.verticaltabs .tabs-wrapper';
                                 $onecss .= ':has(#onetabid-' . $thissection->id . ' a.nav-link.active) ';
                                 $onecss .= '.format_onetopic-tabs { ';

styles.php

@@ -108,8 +108,6 @@
                 }
             }
 
-            // Store background-color for active tabs to use in border CSS.
-            $activebackgroundcolor = null;
             foreach ($styles as $key => $value) {
                 // If exist a unit for the rule, apply it.
                 if (isset($units[$key])) {
@@ -119,11 +117,6 @@
                     $value = $value . 'px';
                 }
 
-                // Capture background-color for active tabs.
-                if ($type === 'active' && $key === 'background-color') {
-                    $activebackgroundcolor = $value;
-                }
-
                 if ($key == 'others') {
                     $csscontent .= $value . ';';
                 } else {
@@ -132,14 +125,6 @@
             }
 
             $csscontent .= '} ';
-
-            // Add border CSS for .format_onetopic-tabs when processing active tab with background-color.
-            if ($type === 'active' && !empty($activebackgroundcolor)) {
-                $csscontent .= '#tabs-tree-start .format_onetopic-tabs { ';
-                $csscontent .= 'border-bottom: 2px solid ' . $activebackgroundcolor . ' !important; ';
-                $csscontent .= 'padding-bottom: 1px; ';
-                $csscontent .= '} ';
-            }
         }
 
         // Clean the CSS for html tags.