MBS-10395: Remove tools from db when uninstalling subplugin (#107)

Author: HannesFunk

classes/plugininfo/aitool.php

@@ -127,7 +127,8 @@ public function uninstall(\progress_trace $progress) {
             return true;
         }
         $sqllike = $DB->sql_like('configkey', '?');
-        $params = ['purpose_%_tool'];
+        $underscoreescaped = $DB->sql_like_escape('_');
+        $params = ["purpose{$underscoreescaped}%{$underscoreescaped}tool%"];
         $select = $sqllike;
         [$insql, $inparams] = $DB->get_in_or_equal($deletedinstanceids);
         $params = array_merge($params, $inparams);

tests/plugininfo/aitool_test.php

@@ -0,0 +1,90 @@
+<?php
+// This file is part of Moodle - http://moodle.org/
+//
+// Moodle is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// Moodle is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
+
+namespace local_ai_manager\plugininfo;
+
+use advanced_testcase;
+
+/**
+ * Test class for the pluginfo/aitool functions.
+ *
+ * @package    local_ai_manager
+ * @copyright  2026 ISB Bayern
+ * @author     Johannes Funk
+ * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+final class aitool_test extends advanced_testcase {
+    /**
+     * Tests the method uninstall
+     *
+     * @covers \local_ai_manager\plugininfo\aitool::uninstall
+     */
+    public function test_uninstall(): void {
+        global $DB;
+
+        $this->resetAfterTest();
+
+        $connectorname = "testconnector";
+
+        $instance = [
+            'connector' => $connectorname,
+        ];
+
+        $id1 = $DB->insert_record('local_ai_manager_instance', (object)$instance);
+        $id2 = $DB->insert_record('local_ai_manager_instance', (object)$instance);
+        // Fake id not equal to either id1 or id2.
+        $otherid = $id1 + $id2;
+
+        // Generate three example configs: one to be deleted, two to be kept.
+        $config1delete = [
+            'configkey' => 'purpose_somepurpose_tool_role_somerole',
+            'configvalue' => $id1,
+        ];
+        $config2keep = [
+            'configkey' => 'another_configkey',
+            'configvalue' => $id2,
+        ];
+        $config3keep = [
+            'configkey' => 'purpose_somepurpose_tool_role_somerole',
+            'configvalue' => $otherid,
+        ];
+
+        $DB->insert_record('local_ai_manager_config', $config1delete);
+        $DB->insert_record('local_ai_manager_config', $config2keep);
+        $DB->insert_record('local_ai_manager_config', $config3keep);
+
+        // Assert all records exist before uninstall.
+        $this->assertTrue($DB->record_exists('local_ai_manager_instance', ['id' => $id1, 'connector' => $connectorname]));
+        $this->assertTrue($DB->record_exists('local_ai_manager_instance', ['id' => $id2, 'connector' => $connectorname]));
+        $this->assertTrue($DB->record_exists('local_ai_manager_config', $config1delete));
+        $this->assertTrue($DB->record_exists('local_ai_manager_config', $config2keep));
+        $this->assertTrue($DB->record_exists('local_ai_manager_config', $config3keep));
+
+        $pluginfo = new aitool();
+        $pluginfo->name = $connectorname;
+
+        $result = $pluginfo->uninstall(new \null_progress_trace());
+        $this->assertTrue($result);
+
+        // No more instances of this connector.
+        $instancecount = $DB->count_records('local_ai_manager_instance', $instance);
+        $this->assertEquals(0, $instancecount);
+
+        $this->assertEquals(0, $DB->count_records('local_ai_manager_config', $config1delete));
+        $this->assertEquals(1, $DB->count_records('local_ai_manager_config', $config2keep));
+        $this->assertEquals(1, $DB->count_records('local_ai_manager_config', $config3keep));
+    }
+}