MBS-10621: Use constants for default endpoints in openai tools

Author: Snl-FGH

tools/chatgpt/classes/connector.php

@@ -36,6 +36,9 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class connector extends \local_ai_manager\base_connector {
+
+    public const DEFAULT_OPENAI_COMPLETIONS_ENDPOINT = 'https://api.openai.com/v1/chat/completions';
+
     #[\Override]
     public function get_models_by_purpose(): array {
         $chatgptmodels =
@@ -177,7 +180,7 @@ protected function get_headers(): array {
 
     #[\Override]
     protected function get_endpoint_url(): string {
-        return $this->instance->get_endpoint() ?: 'https://api.openai.com/v1/chat/completions';
+        return $this->instance->get_endpoint() ?: self::DEFAULT_OPENAI_COMPLETIONS_ENDPOINT;
     }
 
     #[\Override]

tools/chatgpt/classes/instance.php

@@ -34,7 +34,7 @@ class instance extends base_instance {
     protected function extend_form_definition(\MoodleQuickForm $mform): void {
         aitool_option_temperature::extend_form_definition($mform, ['o1', 'o1-mini', 'o3', 'o3-mini', 'o4-mini']);
         aitool_option_azure::extend_form_definition($mform);
-        $defaultendpoint = 'https://api.openai.com/v1/chat/completions';
+        $defaultendpoint = connector::DEFAULT_OPENAI_COMPLETIONS_ENDPOINT;
         $insertat = $mform->elementExists('useglobalapikey') ? 'useglobalapikey' : 'apikey';
         $mform->insertElementBefore(
             $mform->createElement(

tools/chatgpt/tests/connector_test.php

@@ -54,7 +54,7 @@ private function make_connector(string $endpoint): connector {
      */
     public function test_get_endpoint_url_returns_default_when_empty(): void {
         $this->assertEquals(
-            'https://api.openai.com/v1/chat/completions',
+            connector::DEFAULT_OPENAI_COMPLETIONS_ENDPOINT,
             $this->call_get_endpoint_url($this->make_connector(''))
         );
     }

tools/dalle/classes/connector.php

@@ -35,6 +35,8 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class connector extends base_connector {
+
+    public const DEFAULT_DALLE_COMPLETIONS_ENDPOINT = 'https://api.openai.com/v1/images/generations';
     #[\Override]
     public function get_models_by_purpose(): array {
         $modelsbypurpose = base_purpose::get_installed_purposes_array();
@@ -91,7 +93,7 @@ public function get_unit(): unit {
 
     #[\Override]
     protected function get_endpoint_url(): string {
-        return $this->instance->get_endpoint() ?: 'https://api.openai.com/v1/images/generations';
+        return $this->instance->get_endpoint() ?: self::DEFAULT_DALLE_COMPLETIONS_ENDPOINT;
     }
 
     #[\Override]

tools/dalle/classes/instance.php

@@ -32,7 +32,7 @@ class instance extends base_instance {
     #[\Override]
     protected function extend_form_definition(\MoodleQuickForm $mform): void {
         aitool_option_azure::extend_form_definition($mform);
-        $defaultendpoint = 'https://api.openai.com/v1/images/generations';
+        $defaultendpoint = connector::DEFAULT_DALLE_COMPLETIONS_ENDPOINT;
         $insertat = $mform->elementExists('useglobalapikey') ? 'useglobalapikey' : 'apikey';
         $mform->insertElementBefore(
             $mform->createElement(

tools/dalle/tests/connector_test.php

@@ -46,7 +46,7 @@ private function make_connector(string $endpoint): connector {
 
     public function test_get_endpoint_url_returns_default_when_empty(): void {
         $this->assertEquals(
-            'https://api.openai.com/v1/images/generations',
+            connector::DEFAULT_DALLE_COMPLETIONS_ENDPOINT,
             $this->call_get_endpoint_url($this->make_connector(''))
         );
     }

tools/openaitts/classes/connector.php

@@ -32,6 +32,8 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class connector extends \local_ai_manager\base_connector {
+
+    public const DEFAULT_OPENAI_TTS_ENDPOINT = 'https://api.openai.com/v1/audio/speech';
     #[\Override]
     public function get_models_by_purpose(): array {
         $modelsbypurpose = base_purpose::get_installed_purposes_array();
@@ -97,7 +99,7 @@ public function get_unit(): unit {
 
     #[\Override]
     protected function get_endpoint_url(): string {
-        return $this->instance->get_endpoint() ?: 'https://api.openai.com/v1/audio/speech';
+        return $this->instance->get_endpoint() ?: self::DEFAULT_OPENAI_TTS_ENDPOINT;
     }
 
     #[\Override]

tools/openaitts/classes/instance.php

@@ -32,7 +32,7 @@ class instance extends base_instance {
     #[\Override]
     protected function extend_form_definition(\MoodleQuickForm $mform): void {
         aitool_option_azure::extend_form_definition($mform, true);
-        $defaultendpoint = 'https://api.openai.com/v1/audio/speech';
+        $defaultendpoint = connector::DEFAULT_OPENAI_TTS_ENDPOINT;
         $insertat = $mform->elementExists('useglobalapikey') ? 'useglobalapikey' : 'apikey';
         $mform->insertElementBefore(
             $mform->createElement(

tools/openaitts/tests/connector_test.php

@@ -46,7 +46,7 @@ private function make_connector(string $endpoint): connector {
 
     public function test_get_endpoint_url_returns_default_when_empty(): void {
         $this->assertEquals(
-            'https://api.openai.com/v1/audio/speech',
+            connector::DEFAULT_OPENAI_TTS_ENDPOINT,
             $this->call_get_endpoint_url($this->make_connector(''))
         );
     }