fix unit test & remove double space

Author: NJahreis

classes/local/question_generator.php

@@ -74,8 +74,14 @@ public function generate_question(stdClass $dataobject, bool $sendexistingquesti
 
         $provider = get_config('qbank_questiongen', 'provider');
         if ($provider === 'local_ai_manager') {
-            $systemprompt = $primer . " " . $instructions . " " . $example;
-
+            $systemprompt = '## PRIMER\n' .
+                            $primer .
+                            '\n\n## INSTRUCTIONS\n' .
+                            $instructions .
+                            '\n\n## EXAMPLE MOODLE XML QUESTION\n'
+                            . $example;
+
+            // Append existing questions to the prompt if option is chosen.
             if ($sendexistingquestionsascontext) {
                 $questionidsincategory = question_bank::get_finder()->get_questions_from_categories([$dataobject->category], null);
                 if (!empty($questionidsincategory)) {
@@ -89,25 +95,30 @@ public function generate_question(stdClass $dataobject, bool $sendexistingquesti
                         ];
                     }
                     $rs->close();
-
                     $questiontextsinqbankprompt = 'The question that will be generated by you has to be different '
                         . 'from all of the following questions in this JSON string: "'
                         . json_encode($questiontextsinqbankcat) . '"';
-                    $systemprompt = $systemprompt . " " . $questiontextsinqbankprompt;
+
+                    $systemprompt .= '\n\n## EXISTING QUESTIONS GENERATED QUESTIONS MUST DIFFER FROM\n' .
+                                    $questiontextsinqbankprompt;
                 }
             }
-
+            $modeheader = '\n\n## QUESTION GENERATION MODE - ';
             switch ($dataobject->mode) {
                 case story_form::QUESTIONGEN_MODE_TOPIC:
                     $storyprompt =
+                        $modeheader . 'TOPIC\n' .
                         'Create a question about the following topic. Use your own training data to generate it: "' .
                         $story . '"';
                     break;
                 case story_form::QUESTIONGEN_MODE_STORY:
                 case story_form::QUESTIONGEN_MODE_COURSECONTENTS:
                     $storyprompt =
-                        'Create a question from the following contents. '
-                        . 'Only use this content and do not use any training data: "' . $story . '"';
+                        $modeheader . 'COURSE CONTENTS\n' .
+                        'Create a question from the following contents. ' .
+                        'Only use this content and do not use any training data: "' .
+                        $story .
+                        '"';
                     break;
             }
 

tests/local/question_generator_test.php

@@ -71,7 +71,8 @@ public function test_generate_question(): void {
         $this->assertEquals($presetjson->primer, $questionobject->primer);
         $this->assertEquals($presetjson->instructions, $questionobject->instructions);
         $this->assertEquals($presetjson->example, $questionobject->example);
-        $expectedstoryprompt = 'Create a question about the following topic. Use your own training data to generate it: "' .
+        $expectedstoryprompt = '\n\n## QUESTION GENERATION MODE - TOPIC\n' .
+            'Create a question about the following topic. Use your own training data to generate it: "' .
             $dataobject->story . '"';
         $this->assertEquals($expectedstoryprompt, $questionobject->storyprompt);
         $this->assertEmpty($questionobject->questiontextsinqbankprompt);
@@ -110,7 +111,8 @@ public function test_generate_question(): void {
         $this->assertEquals($presetjson->primer, $questionobject->primer);
         $this->assertEquals($presetjson->instructions, $questionobject->instructions);
         $this->assertEquals($presetjson->example, $questionobject->example);
-        $expectedstoryprompt = 'Create a question about the following topic. Use your own training data to generate it: "' .
+        $expectedstoryprompt = '\n\n## QUESTION GENERATION MODE - TOPIC\n' .
+            'Create a question about the following topic. Use your own training data to generate it: "' .
             $dataobject->story . '"';
         $this->assertEquals($expectedstoryprompt, $questionobject->storyprompt);
         $this->assertStringContainsString('The question that will be generated by you has to be different '
@@ -133,7 +135,7 @@ public function test_generate_question(): void {
         $this->assertEquals($presetjson->primer, $questionobject->primer);
         $this->assertEquals($presetjson->instructions, $questionobject->instructions);
         $this->assertEquals($presetjson->example, $questionobject->example);
-        $expectedstoryprompt = 'Create a question from the following contents. '
+        $expectedstoryprompt = '\n\n## QUESTION GENERATION MODE - COURSE CONTENTS\nCreate a question from the following contents. '
             . 'Only use this content and do not use any training data: "' . $dataobject->story . '"';
         $this->assertEquals($expectedstoryprompt, $questionobject->storyprompt);
         $this->assertEmpty($questionobject->questiontextsinqbankprompt);
@@ -148,7 +150,7 @@ public function test_generate_question(): void {
         $this->assertEquals($presetjson->primer, $questionobject->primer);
         $this->assertEquals($presetjson->instructions, $questionobject->instructions);
         $this->assertEquals($presetjson->example, $questionobject->example);
-        $expectedstoryprompt = 'Create a question from the following contents. '
+        $expectedstoryprompt = '\n\n## QUESTION GENERATION MODE - COURSE CONTENTS\nCreate a question from the following contents. '
             . 'Only use this content and do not use any training data: "' . $dataobject->story . '"';
         $this->assertEquals($expectedstoryprompt, $questionobject->storyprompt);
         $this->assertEmpty($questionobject->questiontextsinqbankprompt);