fix: handle arrays that could be undefined

Author: RainbowDashy

dist/index.js

@@ -22,14 +22,17 @@ export const upsertComment = async (res: CheckReleaseResponse) => {
   const prNumber = context.payload.pull_request.number
   // Marker to find the comment to update.
   const startMarker = `<!--BYTEBASE_MARKER-PR_${prNumber}-DO_NOT_EDIT-->`
-  const totalErrorAdviceCount = res.results.reduce(
+  const totalErrorAdviceCount = (res.results ?? []).reduce(
     (acc, result) =>
-      acc + result.advices.filter(advice => advice.status === 'ERROR').length,
+      acc +
+      (result.advices ?? []).filter(advice => advice.status === 'ERROR').length,
     0
   )
-  const totalWarningAdviceCount = res.results.reduce(
+  const totalWarningAdviceCount = (res.results ?? []).reduce(
     (acc, result) =>
-      acc + result.advices.filter(advice => advice.status === 'WARNING').length,
+      acc +
+      (result.advices ?? []).filter(advice => advice.status === 'WARNING')
+        .length,
     0
   )
   // Construct the comment message.
@@ -56,14 +59,14 @@ export const upsertComment = async (res: CheckReleaseResponse) => {
   </thead>
   <tbody>`
 
-  for (const result of res.results) {
+  for (const result of res.results ?? []) {
     if (message.length > maxCommentLength - 1000) {
       break
     }
-    const errorAdvicesCount = result.advices.filter(
+    const errorAdvicesCount = (result.advices ?? []).filter(
       advice => advice.status === 'ERROR'
     ).length
-    const warningAdvicesCount = result.advices.filter(
+    const warningAdvicesCount = (result.advices ?? []).filter(
       advice => advice.status === 'WARNING'
     ).length
     core.debug(`result: ${JSON.stringify(result)}`)

dist/index.js.map

@@ -284,7 +284,7 @@ async function doCheckRelease(
   > = new Map()
   let hasError = false
   let hasWarning = false
-  for (const result of checkReleaseResponse.results) {
+  for (const result of checkReleaseResponse.results ?? []) {
     const file = result.file
     const target = result.target
     const advices = result.advices

src/comment.ts

@@ -7,13 +7,15 @@ export interface httpClient {
 }
 
 export interface CheckReleaseResponse {
-  results: {
-    file: string
-    target: string
-    advices: any[]
-    affectedRows: number
-    riskLevel: string
-  }[]
+  results:
+    | {
+        file: string
+        target: string
+        advices: any[] | undefined
+        affectedRows: number
+        riskLevel: string
+      }[]
+    | undefined
   affectedRows: number
   riskLevel: string
 }