Skip to content

Commit 2b6d42d

Browse files
authored
Add audit policy for javy-codegen crate (#914)
1 parent 7d93287 commit 2b6d42d

File tree

2 files changed

+128
-34
lines changed

2 files changed

+128
-34
lines changed

supply-chain/config.toml

+3-16
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,9 @@ url = "https://raw.githubusercontent.com/mozilla/supply-chain/main/audits.toml"
2525
[policy.javy]
2626
audit-as-crates-io = false
2727

28+
[policy.javy-codegen]
29+
audit-as-crates-io = false
30+
2831
[policy.javy-plugin]
2932
audit-as-crates-io = false
3033

@@ -83,10 +86,6 @@ criteria = "safe-to-deploy"
8386
version = "1.0.0"
8487
criteria = "safe-to-deploy"
8588

86-
[[exemptions.bitflags]]
87-
version = "2.9.0"
88-
criteria = "safe-to-deploy"
89-
9089
[[exemptions.bitvec]]
9190
version = "1.0.1"
9291
criteria = "safe-to-deploy"
@@ -283,10 +282,6 @@ criteria = "safe-to-deploy"
283282
version = "0.2.2"
284283
criteria = "safe-to-deploy"
285284

286-
[[exemptions.getrandom]]
287-
version = "0.3.1"
288-
criteria = "safe-to-deploy"
289-
290285
[[exemptions.getset]]
291286
version = "0.1.3"
292287
criteria = "safe-to-deploy"
@@ -295,10 +290,6 @@ criteria = "safe-to-deploy"
295290
version = "0.26.2"
296291
criteria = "safe-to-deploy"
297292

298-
[[exemptions.gimli]]
299-
version = "0.29.0"
300-
criteria = "safe-to-deploy"
301-
302293
[[exemptions.gimli]]
303294
version = "0.31.1"
304295
criteria = "safe-to-deploy"
@@ -507,10 +498,6 @@ criteria = "safe-to-deploy"
507498
version = "0.6.1"
508499
criteria = "safe-to-deploy"
509500

510-
[[exemptions.rustc-hash]]
511-
version = "2.1.1"
512-
criteria = "safe-to-deploy"
513-
514501
[[exemptions.rustc_version]]
515502
version = "0.2.3"
516503
criteria = "safe-to-deploy"

supply-chain/imports.lock

+125-18
Original file line numberDiff line numberDiff line change
@@ -765,12 +765,6 @@ when = "2025-02-05"
765765
user-id = 73222
766766
user-login = "wasmtime-publish"
767767

768-
[[publisher.wasmparser]]
769-
version = "0.224.1"
770-
when = "2025-02-05"
771-
user-id = 73222
772-
user-login = "wasmtime-publish"
773-
774768
[[publisher.wasmparser]]
775769
version = "0.226.0"
776770
when = "2025-02-19"
@@ -783,18 +777,6 @@ when = "2025-02-05"
783777
user-id = 73222
784778
user-login = "wasmtime-publish"
785779

786-
[[publisher.wasmprinter]]
787-
version = "0.224.1"
788-
when = "2025-02-05"
789-
user-id = 73222
790-
user-login = "wasmtime-publish"
791-
792-
[[publisher.wasmprinter]]
793-
version = "0.226.0"
794-
when = "2025-02-19"
795-
user-id = 73222
796-
user-login = "wasmtime-publish"
797-
798780
[[publisher.wasmtime]]
799781
version = "29.0.1"
800782
when = "2025-01-21"
@@ -1510,6 +1492,34 @@ who = "Nick Fitzgerald <[email protected]>"
15101492
criteria = "safe-to-deploy"
15111493
version = "1.4.1"
15121494

1495+
[[audits.bytecode-alliance.audits.bitflags]]
1496+
who = "Jamey Sharp <[email protected]>"
1497+
criteria = "safe-to-deploy"
1498+
delta = "2.1.0 -> 2.2.1"
1499+
notes = """
1500+
This version adds unsafe impls of traits from the bytemuck crate when built
1501+
with that library enabled, but I believe the impls satisfy the documented
1502+
safety requirements for bytemuck. The other changes are minor.
1503+
"""
1504+
1505+
[[audits.bytecode-alliance.audits.bitflags]]
1506+
who = "Alex Crichton <[email protected]>"
1507+
criteria = "safe-to-deploy"
1508+
delta = "2.3.2 -> 2.3.3"
1509+
notes = """
1510+
Nothing outside the realm of what one would expect from a bitflags generator,
1511+
all as expected.
1512+
"""
1513+
1514+
[[audits.bytecode-alliance.audits.bitflags]]
1515+
who = "Alex Crichton <[email protected]>"
1516+
criteria = "safe-to-deploy"
1517+
delta = "2.4.1 -> 2.6.0"
1518+
notes = """
1519+
Changes in how macros are invoked and various bits and pieces of macro-fu.
1520+
Otherwise no major changes and nothing dealing with `unsafe`.
1521+
"""
1522+
15131523
[[audits.bytecode-alliance.audits.cargo_metadata]]
15141524
who = "Pat Hickey <[email protected]>"
15151525
criteria = "safe-to-deploy"
@@ -1854,6 +1864,36 @@ found in https://chromium-review.googlesource.com/c/chromium/src/+/6187726/2
18541864
'''
18551865
aggregated-from = "https://chromium.googlesource.com/chromium/src/+/main/third_party/rust/chromium_crates_io/supply-chain/audits.toml?format=TEXT"
18561866

1867+
[[audits.google.audits.bitflags]]
1868+
who = "Lukasz Anforowicz <[email protected]>"
1869+
criteria = "safe-to-deploy"
1870+
version = "1.3.2"
1871+
notes = """
1872+
Security review of earlier versions of the crate can be found at
1873+
(Google-internal, sorry): go/image-crate-chromium-security-review
1874+
1875+
The crate exposes a function marked as `unsafe`, but doesn't use any
1876+
`unsafe` blocks (except for tests of the single `unsafe` function). I
1877+
think this justifies marking this crate as `ub-risk-1`.
1878+
1879+
Additional review comments can be found at https://crrev.com/c/4723145/31
1880+
"""
1881+
aggregated-from = "https://chromium.googlesource.com/chromium/src/+/main/third_party/rust/chromium_crates_io/supply-chain/audits.toml?format=TEXT"
1882+
1883+
[[audits.google.audits.bitflags]]
1884+
who = "Lukasz Anforowicz <[email protected]>"
1885+
criteria = "safe-to-deploy"
1886+
delta = "2.6.0 -> 2.8.0"
1887+
notes = "No changes related to `unsafe impl ... bytemuck` pieces from `src/external.rs`."
1888+
aggregated-from = "https://chromium.googlesource.com/chromium/src/+/main/third_party/rust/chromium_crates_io/supply-chain/audits.toml?format=TEXT"
1889+
1890+
[[audits.google.audits.bitflags]]
1891+
who = "Daniel Cheng <[email protected]>"
1892+
criteria = "safe-to-deploy"
1893+
delta = "2.8.0 -> 2.9.0"
1894+
notes = "Adds a straightforward clear() function, but no new unsafe code."
1895+
aggregated-from = "https://chromium.googlesource.com/chromium/src/+/main/third_party/rust/chromium_crates_io/supply-chain/audits.toml?format=TEXT"
1896+
18571897
[[audits.google.audits.cast]]
18581898
who = "George Burgess IV <[email protected]>"
18591899
criteria = "safe-to-run"
@@ -2269,6 +2309,38 @@ criteria = "safe-to-deploy"
22692309
delta = "0.69.2 -> 0.69.4"
22702310
aggregated-from = "https://hg.mozilla.org/mozilla-central/raw-file/tip/supply-chain/audits.toml"
22712311

2312+
[[audits.mozilla.audits.bitflags]]
2313+
who = "Alex Franchuk <[email protected]>"
2314+
criteria = "safe-to-deploy"
2315+
delta = "1.3.2 -> 2.0.2"
2316+
notes = "Removal of some unsafe code/methods. No changes to externals, just some refactoring (mostly internal)."
2317+
aggregated-from = "https://hg.mozilla.org/mozilla-central/raw-file/tip/supply-chain/audits.toml"
2318+
2319+
[[audits.mozilla.audits.bitflags]]
2320+
who = "Nicolas Silva <[email protected]>"
2321+
criteria = "safe-to-deploy"
2322+
delta = "2.0.2 -> 2.1.0"
2323+
aggregated-from = "https://hg.mozilla.org/mozilla-central/raw-file/tip/supply-chain/audits.toml"
2324+
2325+
[[audits.mozilla.audits.bitflags]]
2326+
who = "Teodor Tanasoaia <[email protected]>"
2327+
criteria = "safe-to-deploy"
2328+
delta = "2.2.1 -> 2.3.2"
2329+
aggregated-from = "https://hg.mozilla.org/mozilla-central/raw-file/tip/supply-chain/audits.toml"
2330+
2331+
[[audits.mozilla.audits.bitflags]]
2332+
who = "Mike Hommey <[email protected]>"
2333+
criteria = "safe-to-deploy"
2334+
delta = "2.3.3 -> 2.4.0"
2335+
aggregated-from = "https://hg.mozilla.org/mozilla-central/raw-file/tip/supply-chain/audits.toml"
2336+
2337+
[[audits.mozilla.audits.bitflags]]
2338+
who = "Jan-Erik Rediger <[email protected]>"
2339+
criteria = "safe-to-deploy"
2340+
delta = "2.4.0 -> 2.4.1"
2341+
notes = "Only allowing new clippy lints"
2342+
aggregated-from = "https://raw.githubusercontent.com/mozilla/glean/main/supply-chain/audits.toml"
2343+
22722344
[[audits.mozilla.audits.crypto-common]]
22732345
who = "Mike Hommey <[email protected]>"
22742346
criteria = "safe-to-deploy"
@@ -2398,6 +2470,34 @@ version = "0.2.1"
23982470
notes = "Straightforward crate with no unsafe code, does what it says on the tin."
23992471
aggregated-from = "https://hg.mozilla.org/mozilla-central/raw-file/tip/supply-chain/audits.toml"
24002472

2473+
[[audits.mozilla.audits.getrandom]]
2474+
who = "Chris Martin <[email protected]>"
2475+
criteria = "safe-to-deploy"
2476+
delta = "0.2.15 -> 0.3.1"
2477+
notes = """
2478+
I've looked over all unsafe code, and it appears to be safe, fully initializing the rng buffers.
2479+
In addition, I've checked Linux, Windows, Mac, and Android more thoroughly against API
2480+
documentation.
2481+
"""
2482+
aggregated-from = "https://hg.mozilla.org/mozilla-central/raw-file/tip/supply-chain/audits.toml"
2483+
2484+
[[audits.mozilla.audits.gimli]]
2485+
who = "Alex Franchuk <[email protected]>"
2486+
criteria = "safe-to-deploy"
2487+
version = "0.30.0"
2488+
notes = """
2489+
Unsafe code blocks are sound. Minimal dependencies used. No use of
2490+
side-effectful std functions.
2491+
"""
2492+
aggregated-from = "https://hg.mozilla.org/mozilla-central/raw-file/tip/supply-chain/audits.toml"
2493+
2494+
[[audits.mozilla.audits.gimli]]
2495+
who = "Chris Martin <[email protected]>"
2496+
criteria = "safe-to-deploy"
2497+
delta = "0.30.0 -> 0.29.0"
2498+
notes = "No unsafe code, mostly algorithms and parsing. Very unlikely to cause security issues."
2499+
aggregated-from = "https://hg.mozilla.org/mozilla-central/raw-file/tip/supply-chain/audits.toml"
2500+
24012501
[[audits.mozilla.audits.hashbrown]]
24022502
who = "Mike Hommey <[email protected]>"
24032503
criteria = "safe-to-deploy"
@@ -2508,6 +2608,13 @@ version = "1.1.0"
25082608
notes = "Straightforward crate with no unsafe code, does what it says on the tin."
25092609
aggregated-from = "https://hg.mozilla.org/mozilla-central/raw-file/tip/supply-chain/audits.toml"
25102610

2611+
[[audits.mozilla.audits.rustc-hash]]
2612+
who = "Ben Dean-Kawamura <[email protected]>"
2613+
criteria = "safe-to-deploy"
2614+
delta = "1.1.0 -> 2.1.1"
2615+
notes = "Simple hashing crate, no unsafe code."
2616+
aggregated-from = "https://hg.mozilla.org/mozilla-central/raw-file/tip/supply-chain/audits.toml"
2617+
25112618
[[audits.mozilla.audits.sha2]]
25122619
who = "Mike Hommey <[email protected]>"
25132620
criteria = "safe-to-deploy"

0 commit comments

Comments
 (0)