Skip to content

Commit 711bcff

Browse files
committed
fuzzgen: Unconditionally enable some flags
1 parent 8b222a4 commit 711bcff

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

cranelift/fuzzgen/src/lib.rs

+10-4
Original file line numberDiff line numberDiff line change
@@ -245,13 +245,9 @@ where
245245
// aarch64: https://github.com/bytecodealliance/wasmtime/issues/2735
246246
let bool_settings = [
247247
"enable_alias_analysis",
248-
"enable_simd",
249-
"enable_float",
250-
"enable_atomics",
251248
"enable_safepoints",
252249
"unwind_info",
253250
"preserve_frame_pointers",
254-
"machine_code_cfg_info",
255251
"enable_jump_tables",
256252
"enable_heap_access_spectre_mitigation",
257253
"enable_table_access_spectre_mitigation",
@@ -283,6 +279,16 @@ where
283279
// This is the default, but we should ensure that it wasn't accidentally turned off anywhere.
284280
builder.enable("enable_verifier")?;
285281

282+
// These settings just panic when they're not enabled and we try to use their respective functionality
283+
// so they aren't very interesting to be automatically generated.
284+
builder.enable("enable_atomics")?;
285+
builder.enable("enable_float")?;
286+
builder.enable("enable_simd")?;
287+
288+
// `machine_code_cfg_info` generates additional metadata for the embedder but this doesn't feed back
289+
// into compilation anywhere, we leave it on unconditionally to make sure the generation doesn't panic.
290+
builder.enable("machine_code_cfg_info")?;
291+
286292
Ok(Flags::new(builder))
287293
}
288294

0 commit comments

Comments
 (0)