Skip to content

Is scale_factor calculation inverted in HistogramStats.model_post_init? #86

@quanjnq

Description

@quanjnq

Environment Setup

VIDEX Version: main [d7f16f9]

Observed vs Expected Behavior

In videx_histogram.py line 235:
scale_factor = self.buckets[-1].cum_freq / (1 - self.null_values)

If the goal is to scale cum_freq so that null_values + cum_freq_last = 1, shouldn't the formula be:
scale_factor = (1 - self.null_values) / self.buckets[-1].cum_freq

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions