Skip to content

Commit c8d56f6

Browse files
committed
refactor: 💡 (xgplayer) rm download.js
1 parent 8a1cb72 commit c8d56f6

File tree

3 files changed

+2
-10
lines changed

3 files changed

+2
-10
lines changed

packages/xgplayer/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
"dependencies": {
4242
"danmu.js": ">=1.1.6",
4343
"delegate": "^3.2.0",
44-
"downloadjs": "1.4.7",
4544
"eventemitter3": "^4.0.7",
4645
"xgplayer-subtitles": "3.0.23"
4746
},

packages/xgplayer/src/plugins/download/index.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,7 @@ export default class Download extends IconPlugin {
2828
position: POSITIONS.CONTROLS_RIGHT,
2929
index: 3,
3030
disable: true,
31-
saveAsOptions: {
32-
withCredentials: true
33-
}
31+
saveAsOptions: {}
3432
}
3533
}
3634

@@ -73,7 +71,7 @@ export default class Download extends IconPlugin {
7371
dUrl = url[0].src
7472
}
7573
const newUrl = this.getAbsoluteURL(dUrl)
76-
saveAsWithAuth(newUrl, Object.assign({}, this.config.saveAsOptions))
74+
saveAsWithAuth(newUrl, Object.assign({}, this.config.saveAsOptions || {}))
7775
this.isLock = true
7876
this.timer = window.setTimeout(() => {
7977
this.isLock = false

yarn.lock

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2903,11 +2903,6 @@ dot-prop@^5.1.0:
29032903
dependencies:
29042904
is-obj "^2.0.0"
29052905

2906-
2907-
version "1.4.7"
2908-
resolved "https://registry.yarnpkg.com/downloadjs/-/downloadjs-1.4.7.tgz#f69f96f940e0d0553dac291139865a3cd0101e3c"
2909-
integrity sha512-LN1gO7+u9xjU5oEScGFKvXhYf7Y/empUIIEAGBs1LzUq/rg5duiDrkuH5A2lQGd5jfMOb9X9usDa2oVXwJ0U/Q==
2910-
29112906
dts-bundle-generator@^6.4.0:
29122907
version "6.13.0"
29132908
resolved "https://registry.yarnpkg.com/dts-bundle-generator/-/dts-bundle-generator-6.13.0.tgz#c24df75632917d70168a04b103ee94672e01c4c9"

0 commit comments

Comments
 (0)