feat: Add :patch-triggers? source toggle (default true)

Author: bzg

config.edn.example

@@ -168,6 +168,13 @@
  ;; a list that tightened from :loose to :strict), declare :periods on
  ;; the source — each period can override :command-syntax.
 
+ ;; ---- Patches as triggers (per-source, default true) ---------------------
+ ;;
+ ;; A patch in reply to a bug/request auto-Acks/auto-Owns the parent and
+ ;; propagates :resolved closure. Set false to opt out (the :resolves
+ ;; cross-link is still recorded). Overridable per :periods entry.
+ ;; :patch-triggers? false
+
  ;; ---- Exports -------------------------------------------------------------
 
  ;; Export formats (optional) — per-type feed files generated.

resources/emails.edn

@@ -1724,4 +1724,29 @@
   :email/in-reply-to "<125@test.org>"
   :email/references  "<125@test.org>"
   :email/body-text  "Patch 2.\n\ndiff --git a/style.css b/style.css\n--- a/style.css\n+++ b/style.css\n@@ -1,3 +1,3 @@\n-old\n+new\n"}
+
+ ;; =========================================================================
+ ;; 128-129 — :patch-triggers? false on the source.
+ ;; A bug, then a patch in reply. The bug must NOT be auto-acked/auto-owned
+ ;; on patch creation; only the structural :resolves cross-link is recorded.
+ ;; =========================================================================
+ {:email/id        "128"
+  :email/source      "no-triggers"
+  :email/message-id  "<128@test.org>"
+  :email/subject     "[BUG] segfault on startup"
+  :email/from-address "user@test.org"
+  :email/date-sent  #inst "2026-03-05T09:00:00"
+  :email/ingested-at #inst "2026-03-05T09:00:00"
+  :email/body-text  "Crashes on startup with empty config.\n"}
+
+ {:email/id        "129"
+  :email/source      "no-triggers"
+  :email/message-id  "<129@test.org>"
+  :email/subject     "Re: [BUG] segfault on startup"
+  :email/from-address "dev@test.org"
+  :email/date-sent  #inst "2026-03-05T10:00:00"
+  :email/ingested-at #inst "2026-03-05T10:00:00"
+  :email/in-reply-to "<128@test.org>"
+  :email/references  "<128@test.org>"
+  :email/body-text  "Patch attached.\n\ndiff --git a/init.clj b/init.clj\n--- a/init.clj\n+++ b/init.clj\n@@ -1,3 +1,3 @@\n-old\n+new\n"}
 ]

scripts/validate-config.clj

@@ -101,7 +101,8 @@
                           :source/maintainers :source/notifications
                           :source/expiry :source/awaiting-delay
                           :source/export-formats :source/topics-filter
-                          :source/command-syntax :source/periods])
+                          :source/command-syntax :source/patch-triggers?
+                          :source/periods])
          exactly-one-source-type?))
 
 (s/def :bark/sources
@@ -266,6 +267,14 @@
 (s/def :bark/command-syntax #{:loose :strict})
 (s/def :source/command-syntax :bark/command-syntax)
 
+;; Whether patches on this source act as triggers on the bugs/requests
+;; they resolve. When false, a patch in reply to a bug/request does not
+;; auto-set Acked/Owned, and closing the patch as :resolved does not
+;; close the parent. Default true.
+(s/def :bark/patch-triggers? boolean?)
+(s/def :source/patch-triggers? :bark/patch-triggers?)
+(s/def :period/patch-triggers? :bark/patch-triggers?)
+
 ;; Per-source periods (optional) -- time-windowed overrides for
 ;; :maintainers / :commands / :command-syntax / :labels.
 ;; Each period is a map with optional :start, :end (ISO yyyy-MM-dd) and
@@ -282,7 +291,8 @@
 (s/def ::period-entry
   (s/keys :opt-un [:period/start :period/end
                    :period/maintainers :period/commands
-                   :period/command-syntax :period/labels]))
+                   :period/command-syntax :period/patch-triggers?
+                   :period/labels]))
 (s/def :source/periods (s/coll-of ::period-entry :kind vector? :min-count 1))
 
 ;; Top-level config
@@ -408,6 +418,8 @@
                             (:report-types src)  (conj (str "report-types: " (pr-str (:report-types src))))
                             (:command-syntax src) (conj (str "command-syntax: "
                                                               (name (:command-syntax src))))
+                            (false? (:patch-triggers? src))
+                            (conj "patch-triggers: off")
                             (seq (:maintainers src))
                             (conj (str "maintainers: "
                                        (str/join ", " (:maintainers src))))

src/bark/commands.clj

@@ -368,7 +368,7 @@
                        (conj [:db/add report-eid :report/close-reason close-reason]))]
     (when (seq all-tx) [(vec all-tx) new-sets close-reason])))
 
-(defn apply-triggers! [conn report-eid trig-result email-eid email-mid from-addr]
+(defn apply-triggers! [conn report-eid trig-result email-eid email-mid from-addr source-cfg]
   (when trig-result
     (let [db      (d/db conn)
           current (d/pull db proxy-state-attrs report-eid)
@@ -382,7 +382,12 @@
                   (str "(by " email-mid ")"))
         ;; Propagate trigger-driven closure of a patch to the
         ;; bugs/requests it resolves (no successor in the trigger path).
-        (when (and (= :patch rtype) close-reason (:report/closed new-sets))
+        ;; Sources with `:patch-triggers? false` opt out of the :resolved
+        ;; propagation; :canceled retraction still runs (no-op when no
+        ;; auto-credit was posed in the first place).
+        (when (and (= :patch rtype) close-reason (:report/closed new-sets)
+                   (or (not= :resolved close-reason)
+                       (common/patch-triggers? source-cfg)))
           (rel/propagate-patch-closure! conn report-eid rtype email-eid
                                         close-reason nil))))))
 
@@ -996,7 +1001,8 @@
         (let [voted? (when (and (= :request report-type) from-addr)
                        (apply-vote! conn report-eid from-addr body-text email delivery source-cfg)
                        (some? (detect-vote body-text)))]
-          (apply-triggers! conn report-eid trig-result eid (:email/message-id email) from-addr)
+          (apply-triggers! conn report-eid trig-result eid (:email/message-id email) from-addr
+                           source-cfg)
           (apply-directives! conn report-eid directives eid from-addr is-maint? fail-ctx)
           (boolean (or (seq trig-result) (seq directives) voted?)))))
     false))

src/bark/common.clj

@@ -564,6 +564,15 @@
                          " (expected :loose or :strict)")
                     {:value (:command-syntax source-cfg)}))))
 
+(defn patch-triggers?
+  "True when patches on this source act as triggers on the bugs/requests
+  they resolve: auto-acked + auto-owned on creation, and closure of the
+  patch as :resolved propagates to close the parent. Default true; set
+  `:patch-triggers? false` on a source to opt out."
+  [source-cfg]
+  (let [v (:patch-triggers? source-cfg)]
+    (if (nil? v) true (boolean v))))
+
 ;; ---------------------------------------------------------------------------
 ;; Maintainer tenures (pure -- operate on a seq of tenure maps, no DB access)
 ;; ---------------------------------------------------------------------------

src/bark/digest.clj

@@ -540,12 +540,14 @@
 
 (defn- run-post-creation-hooks!
   "Execute post-creation side effects driven by the plan."
-  [conn report-eid eid email from-addr report-info
+  [conn report-eid eid email from-addr report-info source-cfg
    parent-eids nearest-eids patches plan]
   (when (:link-related plan)
     (link-rel! conn report-eid (:type report-info) email parent-eids))
-  ;; Auto-credit must run AFTER :link-related so :resolves relations exist
-  (when (:auto-credit-resolves plan)
+  ;; Auto-credit must run AFTER :link-related so :resolves relations exist.
+  ;; Skipped on sources with `:patch-triggers? false`.
+  (when (and (:auto-credit-resolves plan)
+             (common/patch-triggers? source-cfg))
     (auto-credit-resolved-reports! conn report-eid email))
   (when (:close-changes plan)
     (close-changes-for-release! conn (:version report-info) email report-eid))
@@ -654,7 +656,7 @@
                   (let [patches (detect/build-patch-entities email)
                         plan    (post-creation-plan report-info nearest-eids parent-eids patches)]
                     (run-post-creation-hooks! conn report-eid eid email from-addr report-info
-                                              parent-eids nearest-eids patches plan)))
+                                              source-cfg parent-eids nearest-eids patches plan)))
 
                 ;; Mark email as fully digested so future re-fetches can skip it.
                 (d/transact! conn [{:db/id eid :email/digested-at (Date.)}])

test/bark/digest_test.clj

@@ -136,12 +136,19 @@
                                 :to "direct@test.org"}
                  "public-list" {:admin "admin@test.org"
                                 :source-type :mailing-list
-                                :list "list.test.org"}})
+                                :list "list.test.org"}
+                 "no-triggers" {:admin "admin@test.org"
+                                :source-type :mailbox
+                                :to "no-triggers@test.org"
+                                :patch-triggers? false}})
 
 (def sources [{:name "public-list"
                :list "list.test.org"}
               {:name "direct"
-               :to "direct@test.org"}])
+               :to "direct@test.org"}
+              {:name "no-triggers"
+               :to "no-triggers@test.org"
+               :patch-triggers? false}])
 
 ;; ---------------------------------------------------------------------------
 ;; DB setup / teardown
@@ -156,6 +163,9 @@
                         :maint-tenure/email  "admin@test.org"
                         :maint-tenure/order  0}
                        {:maint-tenure/source "public-list"
+                        :maint-tenure/email  "admin@test.org"
+                        :maint-tenure/order  0}
+                       {:maint-tenure/source "no-triggers"
                         :maint-tenure/email  "admin@test.org"
                         :maint-tenure/order  0}])
     ;; Insert test emails. Fixtures only set :email/from-address /
@@ -471,6 +481,25 @@
             (is (= "orgweb|kana@test.org|2"
                    (:series/id (:report/series r127))))))
 
+        ;; --- :patch-triggers? false on source (emails 128-129) ---
+        (testing "Source with :patch-triggers? false skips auto-credit"
+          (let [bug   (get-report db "<128@test.org>")
+                patch (get-report db "<129@test.org>")]
+            (is (= :bug   (:report/type bug)))
+            (is (= :patch (:report/type patch)))
+            ;; The :resolves cross-link is still recorded -- only the
+            ;; side effects on the bug are gated.
+            (is (some #(= "<128@test.org>" (:report/message-id %))
+                      (all-related patch))
+                ":resolves cross-link is still recorded")
+            ;; No auto-credit fired on the bug.
+            (is (nil? (:report/acked bug))
+                "auto-acked must NOT fire when :patch-triggers? is false")
+            (is (nil? (:report/owned bug))
+                "auto-owned must NOT fire when :patch-triggers? is false")
+            (is (nil? (:report/closed bug))
+                "the bug must remain open after the patch arrives")))
+
         ;; --- Email 40 patch related to bug ---
         (testing "Email 40 patch related to bug"
           (let [patch (get-report db "<40@test.org>")