Skip to content

Commit 5d0341d

Browse files
committed
update main
1 parent d674370 commit 5d0341d

File tree

2 files changed

+19
-16
lines changed

2 files changed

+19
-16
lines changed

Make.sh

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -79,19 +79,19 @@ EemacsextMake_Checking_shell ()
7979
required_tools_missing=()
8080
required_tools=(make emacs makeinfo tex git less xargs find tar xz date markdown)
8181
count=0
82-
for item in ${required_tools[@]}
82+
for item in "${required_tools[@]}"
8383
do
8484

85-
if [[ -z $(command -v $item) ]];then
86-
required_tools_missing[$count]=$item
85+
if [[ -z $(command -v "$item") ]];then
86+
required_tools_missing["$count"]="$item"
8787
let count++
8888
fi
8989
done
9090
if [ -z "$required_tools_missing" ];then
9191
echo -e "\n-->Shell dependencies satisfied!\n"
9292
else
9393
echo "==========Missing dependency=========="
94-
for item in ${required_tools_missing[@]}
94+
for item in "${required_tools_missing[@]}"
9595
do
9696
echo "Missing '$item'."
9797
done
@@ -126,8 +126,8 @@ EemacsextMake_wait_seconds ()
126126
{
127127
secs=$1
128128
shift
129-
msg=$@
130-
while [ $secs -gt 0 ]
129+
msg="$*"
130+
while [[ $secs -gt 0 ]]
131131
do
132132
printf "\r\033[KWaiting %.d seconds $msg" $((secs--))
133133
sleep 1
@@ -142,14 +142,14 @@ EemacsextMake_GetRepoPath ()
142142

143143
exit_when_error ()
144144
{
145-
local ext_code=$1
146-
if [ -z $ext_code ]
145+
local ext_code="$1"
146+
if [[ -z $ext_code ]]
147147
then
148148
ext_code=1
149149
fi
150-
if [ $? -ne 0 ]
150+
if [[ $? -ne 0 ]]
151151
then
152-
exit $ext_code
152+
exit "$ext_code"
153153
fi
154154
}
155155

@@ -741,6 +741,7 @@ EemacsextMake_Main_All ()
741741
echo -e "\e[32mMain process starting ....\e[0m"
742742
echo -e "=====================================\n"
743743
cd "${EemacsextMake_DIR}"
744+
exit_when_error
744745
EemacsextMake_BuildRecipes
745746
EemacsextMake_BuildElpa_Recipes_Or_Init
746747
EemacsextMake_Finished
@@ -788,12 +789,13 @@ EemacsextMake_Main_Choice ()
788789
exit_when_error
789790
git clean -xfd .
790791
exit_when_error
792+
EemacsextMake_Main_Tidyup_TempBranches
791793
EemacsextMake_Main_Toggle_SubBranch ;;
792794

793795
patch-recipes) EemacsextMake_Main_Tidyup_WorkTree "$(EemacsextMake_GetRepoPath ${EemacsextMake_melpadir})"
794796
EemacsextMake_Make_Melpa_recipes ;;
795797

796-
build-recipes) EemacsextMake_Main_Choice init
798+
build-recipes) :
797799
EemacsextMake_Main_Choice toggle-branches
798800
EemacsextMake_BuildRecipes ;;
799801

eemacs-ext-submodules-parse.el

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -111,16 +111,17 @@ and returning the appended new one.
111111
(defun eemacs-ext/ggsh--error-without-debugger (&rest args)
112112
"Like `error' but never trigger the emacs debugger."
113113
(declare (advertised-calling-convention (string &rest args) "23.1"))
114-
(eemacs-ext/ggsh--without-debugger
115-
(signal
116-
'error
117-
(list (apply #'format-message
114+
(let (msg)
115+
(setq msg
116+
(apply #'format-message
118117
(concat
119118
(if noninteractive
120119
"\033[31m[ERROR]\033[0m "
121120
(propertize "[ERROR] " 'face 'error))
122121
(car args))
123-
(cdr args))))))
122+
(cdr args)))
123+
(if (not noninteractive) (signal 'error (list msg))
124+
(message "%s" msg) (kill-emacs 1))))
124125

125126
(defmacro eemacs-ext/ggsh--with-gitmodule-file-buffer (&rest body)
126127
"Do sth with the current .gitmodule file buffer."

0 commit comments

Comments
 (0)