- Regression when destroying a BackedArenaAllocator in some cases #3332.

- `"a::b:c:d:e:f:0"` was not parsed as a valid ipv6 string.

Author: lerno

lib/std/core/allocators/backed_arena_allocator.c3

@@ -76,6 +76,7 @@ fn void BackedArenaAllocator.reset(&self, sz mark)
 	ExtraPage *last_page = self.last_page;
 	while (last_page && last_page.mark > mark)
 	{
+		self.used = last_page.mark;
 		ExtraPage *to_free = last_page;
 		last_page = last_page.prev_page;
 		_free_page(self, to_free)!!;

lib/std/net/inetaddr.c3

@@ -98,7 +98,7 @@ fn InetAddress? ipv6_from_str(String s)
 			// Check that this is the first ::
 			if (found_zero) return INVALID_IP_STRING~;
 			// Also check that the zeroed section is at least 2
-			if (zero_segment_len < 2) return INVALID_IP_STRING~;
+			if (zero_segment_len < 1) return INVALID_IP_STRING~;
 			// Skip (will be zero by default
 			index += zero_segment_len;
 			found_zero = true;

releasenotes.md

@@ -12,6 +12,8 @@
 
 ### Fixes
 - `$stringify` would sometimes include parens.
+- Regression when destroying a BackedArenaAllocator in some cases #3332.
+- `"a::b:c:d:e:f:0"` was not parsed as a valid ipv6 string.
 
 ## 0.8.1 Change list
 

test/unit/stdlib/net/inetaddr.c3

@@ -48,6 +48,23 @@ fn void test_ipv6()
 	assert(foo.ip6.val == 42541956123769884636017138956568135816);
 }
 
+fn void test_ipv6_parse()
+{
+	assert(net::ipv6_from_str("a::b:c:d:e:f:0")!!.to_tstring() == "000a:0000:000b:000c:000d:000e:000f:0000");
+	assert(net::ipv6_from_str("1:2:3:4:5:6:7::")!!.to_tstring() == "0001:0002:0003:0004:0005:0006:0007:0000");
+	assert(net::ipv6_from_str("::2:3:4:5:6:7:8")!!.to_tstring() == "0000:0002:0003:0004:0005:0006:0007:0008");
+	assert(net::ipv6_from_str("1:2:3:4:5:6::8")!!.to_tstring() == "0001:0002:0003:0004:0005:0006:0000:0008");
+	assert(net::ipv6_from_str("1:2:3:4:5:6:7:8")!!.to_tstring() == "0001:0002:0003:0004:0005:0006:0007:0008");
+
+	assert(@catch(net::ipv6_from_str("1:2:3:4:5:6:7:8:9")));
+	assert(@catch(net::ipv6_from_str("1:2:3:4:5:6:7")));
+	assert(@catch(net::ipv6_from_str("1:2:3:4:5:6:7:8::")));
+	assert(@catch(net::ipv6_from_str("1::2:3:4:5:6:7:8")));
+	assert(@catch(net::ipv6_from_str("1::2::3")));
+	assert(@catch(net::ipv6_from_str("12345::1")));
+	assert(@catch(net::ipv6_from_str("xyz::1")));
+}
+
 fn void test_is_loopback()
 {
 	assert(net::ipv4_from_str("127.0.0.1")!!.is_loopback());