fix: replace removed demo data ref and fix translation format in sale_product_set

Agent-Logs-Url: https://github.com/c4a8-odoo/module-oca-sale-workflow/sessions/fe196e62-1ff2-4cc2-b5ba-08aa317590e6

Co-authored-by: CRogos <1799080+CRogos@users.noreply.github.com>

Author: Copilot

sale_product_set/tests/test_product_set.py

@@ -13,9 +13,29 @@ def setUpClass(cls):
         super().setUpClass()
         cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True))
         cls.so_model = cls.env["sale.order"]
-        cls.so = cls.env.ref("sale.sale_order_6")
         cls.product_set_add = cls.env["sale.product.set.wizard"]
         cls.product_set = cls.env.ref("product_set.product_set_i5_computer")
+        # Create a test product and sale order (demo sale.sale_order_6 removed in 19.0)
+        test_product = cls.env["product.product"].create(
+            {"name": "Test Product For SO", "type": "consu"}
+        )
+        cls.so = cls.so_model.create(
+            {
+                "partner_id": cls.env.ref("base.res_partner_1").id,
+                "order_line": [
+                    (
+                        0,
+                        0,
+                        {
+                            "product_id": test_product.id,
+                            "product_uom_qty": 1,
+                            "price_unit": 10.0,
+                            "name": "Test Product For SO",
+                        },
+                    )
+                ],
+            }
+        )
 
     def _get_wiz(self, ctx=None, **kw):
         vals = {
@@ -165,7 +185,7 @@ def test_discount(self):
         prod_set = self.env["product.set"].create(
             {"name": "Test", "set_line_ids": [(4, set_line.id)]}
         )
-        so = self.env.ref("sale.sale_order_6")
+        so = self.so
         wiz = self.product_set_add.create(
             {"order_id": so.id, "product_set_id": prod_set.id, "quantity": 1}
         )
@@ -186,7 +206,7 @@ def test_product_set_delete_in_wizard(self):
         self.assertEqual(len(self.so.order_line), 3)
 
     def test_add_set_section(self):
-        so = self.env.ref("sale.sale_order_6")
+        so = self.so
         base_line_ids = so.order_line
         count_lines = len(so.order_line)
         product_set_with_section = self.env.ref("product_set.product_set_services")

sale_product_set/wizard/sale_product_set_wizard.py

@@ -51,9 +51,9 @@ def _check_partner(self):
         if self.order_id.partner_id not in allowed_partners:
             raise exceptions.ValidationError(
                 self.env._(
-                    "You can use a sale order assigned "
-                    "only to following partner(s): {}"
-                ).format(", ".join(allowed_partners.mapped("name")))
+                    "You can use a sale order assigned only to following partner(s): %s"
+                )
+                % ", ".join(allowed_partners.mapped("name"))
             )
         return super()._check_partner()