Merge pull request #2033 from anywhy/fix_binance_position_convert

FIX: [binance] fix binance risk position side convert to global

Author: c9s

pkg/exchange/binance/convert_futures.go

@@ -285,7 +285,7 @@ func toGlobalPositionRisk(positions []binanceapi.FuturesPositionRisk) []types.Po
 	for i, position := range positions {
 		retPositions[i] = types.PositionRisk{
 			LiquidationPrice:       position.LiquidationPrice,
-			PositionSide:           types.PositionType(position.PositionSide),
+			PositionSide:           toGlobalPositionSide(position.PositionSide),
 			Symbol:                 position.Symbol,
 			MarkPrice:              position.MarkPrice,
 			EntryPrice:             position.EntryPrice,
@@ -304,3 +304,14 @@ func toGlobalPositionRisk(positions []binanceapi.FuturesPositionRisk) []types.Po
 	}
 	return retPositions
 }
+
+func toGlobalPositionSide(positionSide string) types.PositionType {
+	switch positionSide {
+	case "LONG":
+		return types.PositionLong
+	case "SHORT":
+		return types.PositionShort
+	default:
+		return types.PositionType(positionSide)
+	}
+}

pkg/exchange/binance/convert_futures_test.go

@@ -37,7 +37,7 @@ func TestToGlobalPositionRisk(t *testing.T) {
 
 	risk := risks[0]
 	assert.Equal(t, "BTCUSDT", risk.Symbol)
-	assert.Equal(t, types.PositionType("LONG"), risk.PositionSide)
+	assert.Equal(t, types.PositionLong, risk.PositionSide)
 	assert.Equal(t, fixedpoint.MustNewFromString("51000"), risk.MarkPrice)
 	assert.Equal(t, fixedpoint.MustNewFromString("50000"), risk.EntryPrice)
 	assert.Equal(t, fixedpoint.MustNewFromString("1.0"), risk.PositionAmount)