Skip to content

Commit e6e50ee

Browse files
Enhance tests for submissionName handling in CustomGrantExportMapperImplTest and GrantExportServiceTest. Add assertions to verify mapping of submissionName and handle null cases.
1 parent 8d9c15c commit e6e50ee

2 files changed

Lines changed: 34 additions & 2 deletions

File tree

src/test/java/gov/cabinetoffice/gap/adminbackend/mappers/CustomGrantExportMapperImplTest.java

Lines changed: 32 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,8 @@ class CustomGrantExportMapperImplTest {
5353
.zipFileLocation("location")
5454
.status(GrantExportStatus.COMPLETE)
5555
.name("Some company name")
56-
.submittedDate(FIXED_DATE_TIME)
56+
.submittedDate(FIXED_DATE_TIME)
57+
.submissionName("My Application Name")
5758
.build();
5859
final SubmissionQuestion ORG_NAME_SUBMISSION_QUESTION = SubmissionQuestion.builder()
5960
.questionId("APPLICANT_ORG_NAME")
@@ -81,7 +82,8 @@ class CustomGrantExportMapperImplTest {
8182
.status(SubmissionStatus.SUBMITTED)
8283
.createdBy(GrantApplicant.builder().id(1).userId(UUID.randomUUID().toString()).build())
8384
.definition(submissionDefinition)
84-
.submittedDate(FIXED_DATE_TIME)
85+
.submittedDate(FIXED_DATE_TIME)
86+
.submissionName("My Application Name")
8587
.build();
8688

8789
@Mock
@@ -122,6 +124,34 @@ void grantExportEntityToExportedSubmissions_hasNoSubmission() {
122124

123125
exportedSubmissionsDto.setName(submissionId.toString());
124126
exportedSubmissionsDto.setSubmittedDate(null);
127+
exportedSubmissionsDto.setSubmissionName(null);
125128
assertEquals(exportedSubmissionsDto, exportedSubmissions);
126129
}
130+
131+
@Test
132+
void grantExportEntityToExportedSubmissions_mapsSubmissionName() {
133+
when(submissionRepository.findById(submissionId)).thenReturn(Optional.of(submission));
134+
135+
final ExportedSubmissionsDto exportedSubmissions = customGrantExportMapper.grantExportEntityToExportedSubmissions(grantExport);
136+
137+
assertEquals("My Application Name", exportedSubmissions.getSubmissionName());
138+
}
139+
140+
@Test
141+
void grantExportEntityToExportedSubmissions_handlesNullSubmissionName() {
142+
final Submission submissionWithoutName = Submission.builder()
143+
.id(submissionId)
144+
.scheme(scheme)
145+
.status(SubmissionStatus.SUBMITTED)
146+
.createdBy(GrantApplicant.builder().id(1).userId(UUID.randomUUID().toString()).build())
147+
.definition(submissionDefinition)
148+
.submittedDate(FIXED_DATE_TIME)
149+
.submissionName(null)
150+
.build();
151+
when(submissionRepository.findById(submissionId)).thenReturn(Optional.of(submissionWithoutName));
152+
153+
final ExportedSubmissionsDto exportedSubmissions = customGrantExportMapper.grantExportEntityToExportedSubmissions(grantExport);
154+
155+
assertEquals(null, exportedSubmissions.getSubmissionName());
156+
}
127157
}

src/test/java/gov/cabinetoffice/gap/adminbackend/services/GrantExportServiceTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -216,13 +216,15 @@ void generateExportedSubmissionsListDto() {
216216
.status(GrantExportStatus.COMPLETE)
217217
.name("name2")
218218
.submittedDate(date)
219+
.submissionName("Application Name 2")
219220
.build();
220221
final ExportedSubmissionsDto exportedSubmissionsDto2 = ExportedSubmissionsDto.builder()
221222
.submissionId(submissionId2)
222223
.zipFileLocation("location2")
223224
.status(GrantExportStatus.COMPLETE)
224225
.name("name1")
225226
.submittedDate(oldDate)
227+
.submissionName("Application Name 1")
226228
.build();
227229

228230
when(exportRepository.findByCreatedByAndId_ExportBatchIdAndStatus(SEC_CONTEXT_ADMIN_ID,mockExportId, GrantExportStatus.COMPLETE, pagination))

0 commit comments

Comments
 (0)