Skip to content

Commit c628bc5

Browse files
AlexJump24jbrooksuk
authored andcommitted
feedback + tidy up
1 parent da9f994 commit c628bc5

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

src/Commands/InstallCommand.php

+3-4
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
use Illuminate\Support\Facades\File;
1010
use Illuminate\Support\Sleep;
1111
use Illuminate\Support\Str;
12-
use Laravel\Prompts\Prompt;
1312
use ReflectionClass;
1413
use ReflectionProperty;
1514
use function Laravel\Prompts\confirm;
@@ -24,7 +23,7 @@ class InstallCommand extends Command
2423

2524
protected $description = 'Install Cachet';
2625

27-
public function handle(AppSettings $settings)
26+
public function handle(AppSettings $settings): int
2827
{
2928
intro('Welcome to the Cachet installer!');
3029

@@ -123,8 +122,8 @@ protected function configureDatabaseSettings(AppSettings $settings): AppSettings
123122
}
124123

125124
$descriptionAttributeClass = $descriptionAttribute[0]->newInstance();
126-
$default = $descriptionAttributeClass->getDefault();
127-
$required = $descriptionAttributeClass->getRequired();
125+
$default = $descriptionAttributeClass->default();
126+
$required = $descriptionAttributeClass->required();
128127

129128
if ($required === false) {
130129
return;

src/Settings/Attributes/Description.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@ final class Description
99
{
1010
public function __construct(private readonly string $default, private readonly bool $required = true) {}
1111

12-
public function getDefault(): string
12+
public function default(): string
1313
{
1414
return $this->default;
1515
}
1616

17-
public function getRequired(): bool
17+
public function required(): bool
1818
{
1919
return $this->required;
2020
}

0 commit comments

Comments
 (0)