remove .pre-commit-config.yaml if all hooks are disabled

Author: jashandeep-sohi

src/modules/integrations/git-hooks.nix

@@ -17,6 +17,8 @@ let
     mkdir -p $out/bin
     ln -s ${cfg.package}/bin/pre-commit $out/bin/pre-commit
   '';
+
+  anyEnabled = ((lib.filterAttrs (id: value: value.enable) cfg.hooks) != { });
 in
 {
   imports = [
@@ -40,20 +42,33 @@ in
     description = "Integration with https://github.com/cachix/git-hooks.nix";
   };
 
-  config = lib.mkIf ((lib.filterAttrs (id: value: value.enable) cfg.hooks) != { }) {
-    ci = [ cfg.run ];
-    # Add the packages for any enabled hooks at the end to avoid overriding the language-defined packages.
-    packages = lib.mkAfter ([ packageBin ] ++ (cfg.enabledPackages or [ ]));
-    tasks = {
-      # TODO: split installation script into status + exec
-      "devenv:git-hooks:install" = {
-        exec = cfg.installationScript;
-        before = [ "devenv:enterShell" ];
-      };
-      "devenv:git-hooks:run" = {
-        exec = "pre-commit run -a";
-        before = [ "devenv:enterTest" ];
+  config = lib.mkMerge [
+    (lib.mkIf (!anyEnabled) {
+      # Remove .pre-commit-config.yaml if it exists and is in the nix store
+      enterShell = ''
+        preCommitConfig="$DEVENV_ROOT/.pre-commit-config.yaml"
+        if $(nix-store --quiet --verify-path "$preCommitConfig" > /dev/null 2>&1); then
+          echo Removing "$preCommitConfig"
+          rm -rf "$preCommitConfig"
+        fi
+      '';
+    })
+
+    (lib.mkIf anyEnabled {
+      ci = [ cfg.run ];
+      # Add the packages for any enabled hooks at the end to avoid overriding the language-defined packages.
+      packages = lib.mkAfter ([ packageBin ] ++ (cfg.enabledPackages or [ ]));
+      tasks = {
+        # TODO: split installation script into status + exec
+        "devenv:git-hooks:install" = {
+          exec = cfg.installationScript;
+          before = [ "devenv:enterShell" ];
+        };
+        "devenv:git-hooks:run" = {
+          exec = "pre-commit run -a";
+          before = [ "devenv:enterTest" ];
+        };
       };
-    };
-  };
+    })
+  ];
 }

tests/git-hooks-all-disabled/.setup.sh

@@ -0,0 +1,6 @@
+if ! test -f "$DEVENV_ROOT/.pre-commit-config.yaml"; then
+  echo "Test not setup correctly: .pre-commit-config.yaml not found"
+  exit 1
+fi
+
+echo "{ lib, ... }: { git-hooks.hooks.no-op.enable = lib.mkForce false; }" > devenv.local.nix

tests/git-hooks-all-disabled/devenv.nix

@@ -0,0 +1,19 @@
+# Assert that .pre-commit-config.yaml is removed when all hooks are disabled
+{
+  git-hooks.hooks = {
+    no-op = {
+      enable = true;
+      name = "No Op";
+      pass_filenames = false;
+      raw.always_run = true;
+      entry = "true";
+    };
+  };
+
+  enterTest = ''
+    if test -f "$DEVENV_ROOT/.pre-commit-config.yaml"; then
+      echo ".pre-commit-config.yaml not removed"
+      exit 1
+    fi
+  '';
+}