Skip to content

Commit 9206e8a

Browse files
committed
Tweak some comments
1 parent 1426c97 commit 9206e8a

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

modules/caddyhttp/responsewriter.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,9 +170,10 @@ func (rr *responseRecorder) WriteHeader(statusCode int) {
170170
return
171171
}
172172

173-
// save statusCode in case http middleware upgrading websocket
173+
// save statusCode always, in case HTTP middleware upgrades websocket
174174
// connections by manually setting headers and writing status 101
175175
rr.statusCode = statusCode
176+
176177
// 1xx responses aren't final; just informational
177178
if statusCode < 100 || statusCode > 199 {
178179
rr.wroteHeader = true

modules/caddyhttp/server.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
239239
return
240240
}
241241

242-
repl.Set("http.response.status", wrec.Status())
242+
repl.Set("http.response.status", wrec.Status()) // will be 0 if no response is written by us (Go will write 200 to client)
243243
repl.Set("http.response.size", wrec.Size())
244244
repl.Set("http.response.duration", duration)
245245
repl.Set("http.response.duration_ms", duration.Seconds()*1e3) // multiply seconds to preserve decimal (see #4666)

0 commit comments

Comments
 (0)