reverseproxy: log status 499 instead of 0 when client disconnects#7827
Merged
steadytao merged 1 commit intoJun 18, 2026
Merged
Conversation
|
|
steadytao
approved these changes
Jun 18, 2026
steadytao
left a comment
steadytao
left a comment
Member
There was a problem hiding this comment.
LGTM. When the downstream client cancels before Caddy writes response headers logging 499 is more useful than 0 and this still avoids retrying or marking the upstream unhealthy, thanks for the PR @larrasket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7396
Assistance Disclosure
Claude Sonnet 4.6 was used to generate the test in
modules/caddyhttp/reverseproxy/client_disconnect_test.go, with a small tweak.