Skip to content

Commit 03cffeb

Browse files
committed
Update a couple comments
1 parent 2f6011a commit 03cffeb

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

handshake.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ func (cfg *Config) getCertDuringHandshake(hello *tls.ClientHelloInfo, loadIfNece
293293
// TODO: As suggested here, https://caddy.community/t/error-tls-alert-internal-error-592-again/13272/30?u=matt,
294294
// it might be a good idea to check with the DecisionFunc or allowlist first before even loading the certificate
295295
// from storage, since if we can't renew it, why should we even try serving it (it will just get evicted after
296-
// we get a return value of false anyway)?
296+
// we get a return value of false anyway)? See issue #174
297297
loadedCert, err := cfg.CacheManagedCertificate(ctx, name)
298298
if errors.Is(err, fs.ErrNotExist) {
299299
// If no exact match, try a wildcard variant, which is something we can still use

maintain.go

-1
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ func (certCache *Cache) maintainAssets(panicCount int) {
7979
case <-certCache.stopChan:
8080
renewalTicker.Stop()
8181
ocspTicker.Stop()
82-
// TODO: stop any in-progress maintenance operations and clear locks we made (this might be done now with our use of context)
8382
if log != nil {
8483
log.Info("stopped background certificate maintenance")
8584
}

0 commit comments

Comments
 (0)