Skip to content

Commit 2e22c6f

Browse files
committed
Report issuers tried on cert_failed (fix #204)
Instead of assuming issuerUsed is non-nil in the error case
1 parent ab3db75 commit 2e22c6f

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

config.go

+5-2
Original file line numberDiff line numberDiff line change
@@ -539,7 +539,10 @@ func (cfg *Config) obtainCert(ctx context.Context, name string, interactive bool
539539
// try to obtain from each issuer until we succeed
540540
var issuedCert *IssuedCertificate
541541
var issuerUsed Issuer
542+
var issuerKeys []string
542543
for i, issuer := range issuers {
544+
issuerKeys = append(issuerKeys, issuer.IssuerKey())
545+
543546
if log != nil {
544547
log.Debug(fmt.Sprintf("trying issuer %d/%d", i+1, len(cfg.Issuers)),
545548
zap.String("issuer", issuer.IssuerKey()))
@@ -576,7 +579,7 @@ func (cfg *Config) obtainCert(ctx context.Context, name string, interactive bool
576579
cfg.emit(ctx, "cert_failed", map[string]any{
577580
"renewal": false,
578581
"identifier": name,
579-
"issuer": issuerUsed.IssuerKey(),
582+
"issuers": issuerKeys,
580583
"error": err,
581584
})
582585

@@ -603,7 +606,7 @@ func (cfg *Config) obtainCert(ctx context.Context, name string, interactive bool
603606
cfg.emit(ctx, "cert_obtained", map[string]any{
604607
"renewal": false,
605608
"identifier": name,
606-
"issuer": issuerUsed.IssuerKey(),
609+
"issuers": issuerUsed.IssuerKey(),
607610
"storage_key": certRes.NamesKey(),
608611
})
609612

0 commit comments

Comments
 (0)