Skip to content

Commit 4293198

Browse files
committed
Allow empty DNS record names (fix #314)
1 parent c1f1d52 commit 4293198

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

solvers.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -547,14 +547,15 @@ func (s *DNSManager) getDNSPresentMemory(dnsName, recType, value string) (dnsPre
547547
defer s.recordsMu.Unlock()
548548

549549
var memory dnsPresentMemory
550+
var found bool
550551
for _, mem := range s.records[dnsName] {
551552
if mem.zoneRec.record.Type == recType && mem.zoneRec.record.Value == value {
552553
memory = mem
554+
found = true
553555
break
554556
}
555557
}
556-
557-
if memory.zoneRec.record.Name == "" {
558+
if !found {
558559
return dnsPresentMemory{}, fmt.Errorf("no memory of presenting a DNS record for %q (usually OK if presenting also failed)", dnsName)
559560
}
560561

0 commit comments

Comments
 (0)