ari: Fix panic when loaded cert has no RetryAfter

mholt · mholt · commit aad674cda5ba · 2024-09-05T10:53:29.000-06:00
diff --git a/maintain.go b/maintain.go
@@ -427,7 +427,7 @@ func (cfg *Config) storageHasNewerARI(ctx context.Context, cert Certificate) (bo
 	// or if the one in storage has a later RetryAfter (though I suppose
 	// it's not guaranteed, typically those will move forward in time)
 	if (!cert.ari.HasWindow() && storedCertData.RenewalInfo.HasWindow()) ||
-		storedCertData.RenewalInfo.RetryAfter.After(*cert.ari.RetryAfter) {
+		(cert.ari.RetryAfter == nil || storedCertData.RenewalInfo.RetryAfter.After(*cert.ari.RetryAfter)) {
 		return true, *storedCertData.RenewalInfo, nil
 	}
 	return false, acme.RenewalInfo{}, nil

Original file line number	Diff line number	Diff line change
`@@ -427,7 +427,7 @@ func (cfg *Config) storageHasNewerARI(ctx context.Context, cert Certificate) (bo`
`427`	`427`	`// or if the one in storage has a later RetryAfter (though I suppose`
`428`	`428`	`// it's not guaranteed, typically those will move forward in time)`
`429`	`429`	`if (!cert.ari.HasWindow() && storedCertData.RenewalInfo.HasWindow()) \|\|`
`430`		`- storedCertData.RenewalInfo.RetryAfter.After(*cert.ari.RetryAfter) {`
	`430`	`+ (cert.ari.RetryAfter == nil \|\| storedCertData.RenewalInfo.RetryAfter.After(*cert.ari.RetryAfter)) {`
`431`	`431`	`return true, *storedCertData.RenewalInfo, nil`
`432`	`432`	`}`
`433`	`433`	`return false, acme.RenewalInfo{}, nil`