Skip to content

NewContinueAsNewError should not "continue" if the context was canceled #935

Open
@tscolari

Description

@tscolari

I've noticed that the function NewContinueAsNewError(ctx, ...) will not take into consideration that the context it was given was canceled.

I couldn't find this behavior documented anywhere and on slack the suggestion was that this should not happen and to create an issue here.

Would it make sense that if the workflow was canceled (and so the context), NewContinueAsNewError() propagated that CanceledError instead of creating a new error?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions