Skip to content

Commit b1fda30

Browse files
authored
fix gRPC query mappers (#736)
1 parent 7353f76 commit b1fda30

File tree

2 files changed

+19
-11
lines changed

2 files changed

+19
-11
lines changed

src/main/java/com/uber/cadence/internal/compatibility/proto/RequestMapper.java

+18-10
Original file line numberDiff line numberDiff line change
@@ -118,10 +118,12 @@ public static CountWorkflowExecutionsRequest countWorkflowExecutionsRequest(
118118
if (t == null) {
119119
return null;
120120
}
121-
return CountWorkflowExecutionsRequest.newBuilder()
122-
.setDomain(t.getDomain())
123-
.setQuery(t.getQuery())
124-
.build();
121+
CountWorkflowExecutionsRequest.Builder request =
122+
CountWorkflowExecutionsRequest.newBuilder().setDomain(t.getDomain());
123+
if (t.getQuery() != null) {
124+
request.setQuery(t.getQuery());
125+
}
126+
return request.build();
125127
}
126128

127129
public static DescribeTaskListRequest describeTaskListRequest(
@@ -145,11 +147,13 @@ public static ListArchivedWorkflowExecutionsRequest listArchivedWorkflowExecutio
145147
ListArchivedWorkflowExecutionsRequest.Builder request =
146148
ListArchivedWorkflowExecutionsRequest.newBuilder()
147149
.setDomain(t.getDomain())
148-
.setPageSize(t.getPageSize())
149-
.setQuery(t.getQuery());
150+
.setPageSize(t.getPageSize());
150151
if (t.getNextPageToken() != null) {
151152
request.setNextPageToken(arrayToByteString(t.getNextPageToken()));
152153
}
154+
if (t.getQuery() != null) {
155+
request.setQuery(t.getQuery());
156+
}
153157
return request.build();
154158
}
155159

@@ -373,11 +377,13 @@ public static ScanWorkflowExecutionsRequest scanWorkflowExecutionsRequest(
373377
ScanWorkflowExecutionsRequest.Builder request =
374378
ScanWorkflowExecutionsRequest.newBuilder()
375379
.setDomain(t.getDomain())
376-
.setPageSize(t.getPageSize())
377-
.setQuery(t.getQuery());
380+
.setPageSize(t.getPageSize());
378381
if (t.getNextPageToken() != null) {
379382
request.setNextPageToken(arrayToByteString(t.getNextPageToken()));
380383
}
384+
if (t.getQuery() != null) {
385+
request.setQuery(t.getQuery());
386+
}
381387
return request.build();
382388
}
383389

@@ -584,11 +590,13 @@ public static ListWorkflowExecutionsRequest listWorkflowExecutionsRequest(
584590
ListWorkflowExecutionsRequest.Builder request =
585591
ListWorkflowExecutionsRequest.newBuilder()
586592
.setDomain(t.getDomain())
587-
.setPageSize(t.getPageSize())
588-
.setQuery(t.getQuery());
593+
.setPageSize(t.getPageSize());
589594
if (t.getNextPageToken() != null) {
590595
request.setNextPageToken(arrayToByteString(t.getNextPageToken()));
591596
}
597+
if (t.getQuery() != null) {
598+
request.setQuery(t.getQuery());
599+
}
592600
return request.build();
593601
}
594602

src/main/java/com/uber/cadence/internal/compatibility/proto/TypeMapper.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ static ClusterReplicationConfiguration clusterReplicationConfiguration(
189189

190190
static WorkflowQuery workflowQuery(com.uber.cadence.WorkflowQuery t) {
191191
if (t == null) {
192-
return WorkflowQuery.newBuilder().build();
192+
return null;
193193
}
194194
return WorkflowQuery.newBuilder()
195195
.setQueryType(t.getQueryType())

0 commit comments

Comments
 (0)