Fixed doNotRetry RetryOptions (#182)

* Added doNotRetry to RetryOptions in testAsyncActivityRetryOptionsChange

* Added type adapter for Class objects to DataConverter

* Added JsonDataConverter.testClass and fixed the bug in JsonDataConverter

Author: mfateev

src/main/java/com/uber/cadence/converter/JsonDataConverter.java

@@ -76,6 +76,7 @@ public final class JsonDataConverter implements DataConverter {
   private static final Object[] EMPTY_OBJECT_ARRAY = new Object[0];
   public static final String TYPE_FIELD_NAME = "type";
   public static final String JSON_CONVERTER_TYPE = "JSON";
+  public static final String CLASS_NAME_FIELD_NAME = "className";
   private final Gson gson;
   private final JsonParser parser = new JsonParser();
 
@@ -195,7 +196,7 @@ public void write(JsonWriter out, T value) throws IOException {
           @SuppressWarnings("unchecked")
           public T read(JsonReader in) throws IOException {
             in.beginObject();
-            if (!in.nextName().equals("type")) {
+            if (!in.nextName().equals(TYPE_FIELD_NAME)) {
               throw new IOException("Cannot deserialize DataConverter. Missing type field");
             }
             String value = in.nextString();
@@ -208,6 +209,35 @@ public T read(JsonReader in) throws IOException {
           }
         };
       }
+      if (Class.class.isAssignableFrom(typeToken.getRawType())) {
+        return new TypeAdapter<T>() {
+          @Override
+          public void write(JsonWriter out, T value) throws IOException {
+            out.beginObject();
+            String className = ((Class) value).getName();
+            out.name(CLASS_NAME_FIELD_NAME).value(className);
+            out.endObject();
+          }
+
+          @Override
+          public T read(JsonReader in) throws IOException {
+            in.beginObject();
+            if (!in.nextName().equals(CLASS_NAME_FIELD_NAME)) {
+              throw new IOException(
+                  "Cannot deserialize class. Missing " + CLASS_NAME_FIELD_NAME + " field");
+            }
+            String className = in.nextString();
+            try {
+              @SuppressWarnings("unchecked")
+              T result = (T) Class.forName(className);
+              in.endObject();
+              return result;
+            } catch (ClassNotFoundException e) {
+              throw new RuntimeException(e);
+            }
+          }
+        };
+      }
       if (!Throwable.class.isAssignableFrom(typeToken.getRawType())) {
         return null; // this class only serializes 'Throwable' and its subtypes
       }

src/test/java/com/uber/cadence/converter/JsonDataConverterTest.java

@@ -74,4 +74,13 @@ public void testUUIDList() throws NoSuchMethodException {
     List<UUID> result = (List<UUID>) converter.fromDataArray(data, arg)[0];
     assertEquals(result.toString(), list, result);
   }
+
+  @Test
+  public void testClass() {
+    DataConverter converter = JsonDataConverter.getInstance();
+    byte[] data = converter.toData(this.getClass());
+    @SuppressWarnings("unchecked")
+    Class result = converter.fromData(data, Class.class, Class.class);
+    assertEquals(result.toString(), this.getClass(), result);
+  }
 }

src/test/java/com/uber/cadence/workflow/WorkflowTest.java

@@ -560,6 +560,7 @@ public String execute(String taskList) {
                 .setMinimumAttempts(1)
                 .setMaximumInterval(Duration.ofSeconds(1))
                 .setInitialInterval(Duration.ofSeconds(1))
+                .setDoNotRetry(NullPointerException.class)
                 .setMaximumAttempts(3)
                 .build());
       } else {
@@ -569,6 +570,7 @@ public String execute(String taskList) {
                 .setMaximumInterval(Duration.ofSeconds(1))
                 .setInitialInterval(Duration.ofSeconds(1))
                 .setMaximumAttempts(2)
+                .setDoNotRetry(NullPointerException.class)
                 .build());
       }
       this.activities = Workflow.newActivityStub(TestActivities.class, options.build());