From 094471942147825fca038c41c3704facbc063df8 Mon Sep 17 00:00:00 2001 From: Adil Hafeez Date: Wed, 16 Oct 2019 23:11:32 -0700 Subject: [PATCH 1/2] Don't proceed further if domain does not exist --- cmd/samples/common/sample_helper.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/samples/common/sample_helper.go b/cmd/samples/common/sample_helper.go index 77ff8628..396c9930 100644 --- a/cmd/samples/common/sample_helper.go +++ b/cmd/samples/common/sample_helper.go @@ -80,7 +80,7 @@ func (h *SampleHelper) SetupServiceConfig() { domainClient, _ := h.Builder.BuildCadenceDomainClient() _, err = domainClient.Describe(context.Background(), h.Config.DomainName) if err != nil { - logger.Info("Domain doesn't exist", zap.String("Domain", h.Config.DomainName), zap.Error(err)) + logger.Fatal("Domain doesn't exist", zap.String("Domain", h.Config.DomainName), zap.Error(err)) } else { logger.Info("Domain successfully registered.", zap.String("Domain", h.Config.DomainName)) } From ffaeeb3ca0fff7f48e257b3385d14250aac888a0 Mon Sep 17 00:00:00 2001 From: Adil Hafeez Date: Thu, 17 Oct 2019 00:17:30 -0700 Subject: [PATCH 2/2] better logging --- cmd/samples/common/sample_helper.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/samples/common/sample_helper.go b/cmd/samples/common/sample_helper.go index 396c9930..cc01dcb2 100644 --- a/cmd/samples/common/sample_helper.go +++ b/cmd/samples/common/sample_helper.go @@ -80,7 +80,7 @@ func (h *SampleHelper) SetupServiceConfig() { domainClient, _ := h.Builder.BuildCadenceDomainClient() _, err = domainClient.Describe(context.Background(), h.Config.DomainName) if err != nil { - logger.Fatal("Domain doesn't exist", zap.String("Domain", h.Config.DomainName), zap.Error(err)) + logger.Fatal("Error occurred while calling Describe API", zap.String("Domain", h.Config.DomainName), zap.Error(err)) } else { logger.Info("Domain successfully registered.", zap.String("Domain", h.Config.DomainName)) }