feat(schedule-actions): add delete confirmation action (#1428)

Assem-Uber · web-flow · commit 19dfdd715a51 · 2026-07-02T18:25:28.000+02:00
## Summary Adds the Delete schedule action to the schedule-actions menu as a confirmation-only modal with a warning banner. On success, the UI navigates to the schedules list and invalidates `listSchedules`. Rebased onto `master` after #1427 merged; this PR now contains only the delete UI slice (4 commits).
diff --git a/src/config/dynamic/resolvers/__tests__/schedule-actions-enabled.node.ts b/src/config/dynamic/resolvers/__tests__/schedule-actions-enabled.node.ts
@@ -26,6 +26,7 @@ describe(scheduleActionsEnabled.name, () => {
     expect(result).toEqual({
       pause: 'ENABLED',
       resume: 'ENABLED',
+      delete: 'ENABLED',
     });
   });
 
@@ -40,6 +41,7 @@ describe(scheduleActionsEnabled.name, () => {
     expect(result).toEqual({
       pause: 'DISABLED_UNAUTHORIZED',
       resume: 'DISABLED_UNAUTHORIZED',
+      delete: 'DISABLED_UNAUTHORIZED',
     });
   });
 
@@ -54,6 +56,7 @@ describe(scheduleActionsEnabled.name, () => {
     expect(result).toEqual({
       pause: 'DISABLED_DEFAULT',
       resume: 'DISABLED_DEFAULT',
+      delete: 'DISABLED_DEFAULT',
     });
   });
 });
diff --git a/src/config/dynamic/resolvers/schedule-actions-enabled.constants.ts b/src/config/dynamic/resolvers/schedule-actions-enabled.constants.ts
@@ -4,16 +4,19 @@ export const AUTHORIZED_SCHEDULE_ACTIONS_CONFIG: ScheduleActionsEnabledConfig =
   {
     pause: 'ENABLED',
     resume: 'ENABLED',
+    delete: 'ENABLED',
   };
 
 export const UNAUTHORIZED_SCHEDULE_ACTIONS_CONFIG: ScheduleActionsEnabledConfig =
   {
     pause: 'DISABLED_UNAUTHORIZED',
     resume: 'DISABLED_UNAUTHORIZED',
+    delete: 'DISABLED_UNAUTHORIZED',
   };
 
 export const DEFAULT_DISABLED_SCHEDULE_ACTIONS_CONFIG: ScheduleActionsEnabledConfig =
   {
     pause: 'DISABLED_DEFAULT',
     resume: 'DISABLED_DEFAULT',
+    delete: 'DISABLED_DEFAULT',
   };
diff --git a/src/config/dynamic/resolvers/schedule-actions-enabled.types.ts b/src/config/dynamic/resolvers/schedule-actions-enabled.types.ts
@@ -1,6 +1,6 @@
 import type SCHEDULE_ACTIONS_DISABLED_VALUES_CONFIG from './schedule-actions-disabled-values.config';
 
-export type ScheduleActionID = 'pause' | 'resume';
+export type ScheduleActionID = 'pause' | 'resume' | 'delete';
 
 export type ScheduleActionDisabledValue =
   (typeof SCHEDULE_ACTIONS_DISABLED_VALUES_CONFIG)[number];
diff --git a/src/config/dynamic/resolvers/schemas/resolver-schemas.ts b/src/config/dynamic/resolvers/schemas/resolver-schemas.ts
@@ -74,6 +74,7 @@ const resolverSchemas: ResolverSchemas = {
     returnType: z.object({
       pause: scheduleActionsEnabledValueSchema,
       resume: scheduleActionsEnabledValueSchema,
+      delete: scheduleActionsEnabledValueSchema,
     }),
   },
   CRON_LIST_ENABLED: {
diff --git a/src/utils/config/__fixtures__/resolved-config-values.ts b/src/utils/config/__fixtures__/resolved-config-values.ts
@@ -53,6 +53,7 @@ const mockResolvedConfigValues: LoadedConfigResolvedValues = {
   SCHEDULE_ACTIONS_ENABLED: {
     pause: 'ENABLED',
     resume: 'ENABLED',
+    delete: 'ENABLED',
   },
   SCHEDULES_ENABLED: false,
   WORKFLOWS_LIST_ENABLED: false,
diff --git a/src/views/schedule-actions/__fixtures__/schedule-actions-config.tsx b/src/views/schedule-actions/__fixtures__/schedule-actions-config.tsx
@@ -1,11 +1,13 @@
 import {
+  MdDeleteOutline,
   MdOutlineWarningAmber,
   MdPauseCircleOutline,
   MdPlayCircleOutline,
 } from 'react-icons/md';
 import { z } from 'zod';
 
 import { ScheduleCatchUpPolicy } from '@/__generated__/proto-ts/uber/cadence/api/v1/ScheduleCatchUpPolicy';
+import { type DeleteScheduleResponse } from '@/route-handlers/delete-schedule/delete-schedule.types';
 import { type PauseScheduleResponse } from '@/route-handlers/pause-schedule/pause-schedule.types';
 import { type UnpauseScheduleResponse } from '@/route-handlers/unpause-schedule/unpause-schedule.types';
 
@@ -95,7 +97,32 @@ export const mockResumeActionConfig: ScheduleAction<
   renderSuccessMessage: () => 'Mock resume notification',
 };
 
+export const mockDeleteActionConfig: ScheduleAction<DeleteScheduleResponse> = {
+  id: 'delete',
+  label: 'Delete',
+  subtitle: 'Mock delete a schedule',
+  modal: {
+    banner: {
+      kind: 'warning',
+      icon: MdOutlineWarningAmber,
+      render: () =>
+        'Deletes the schedule permanently. In-progress workflow runs are not affected.',
+    },
+    withForm: false,
+  },
+  icon: MdDeleteOutline,
+  getRunnableStatus: () => 'RUNNABLE',
+  apiRoute: (params) =>
+    `/api/domains/${params.domain}/${params.cluster}/schedules/${params.scheduleId}`,
+  httpMethod: 'DELETE',
+  renderSuccessMessage: () => 'Schedule deleted.',
+  onSuccess: ({ router, params }) => {
+    router.push(`/domains/${params.domain}/${params.cluster}/schedules`);
+  },
+};
+
 export const mockScheduleActionsConfig = [
   mockPauseActionConfig,
   mockResumeActionConfig,
+  mockDeleteActionConfig,
 ] as const;
diff --git a/src/views/schedule-actions/__tests__/schedule-actions.test.tsx b/src/views/schedule-actions/__tests__/schedule-actions.test.tsx
@@ -152,6 +152,7 @@ function setup({
             {
               pause: 'ENABLED',
               resume: 'ENABLED',
+              delete: 'ENABLED',
             },
             { status: 200 }
           );
diff --git a/src/views/schedule-actions/config/schedule-actions.config.ts b/src/views/schedule-actions/config/schedule-actions.config.ts
@@ -1,9 +1,11 @@
 import {
+  MdDeleteOutline,
   MdOutlineWarningAmber,
   MdPauseCircleOutline,
   MdPlayCircleOutline,
 } from 'react-icons/md';
 
+import { type DeleteScheduleResponse } from '@/route-handlers/delete-schedule/delete-schedule.types';
 import { type PauseScheduleResponse } from '@/route-handlers/pause-schedule/pause-schedule.types';
 import { type UnpauseScheduleResponse } from '@/route-handlers/unpause-schedule/unpause-schedule.types';
 
@@ -74,9 +76,42 @@ const resumeScheduleActionConfig: ScheduleAction<
   renderSuccessMessage: () => 'Schedule has been resumed.',
 };
 
+const deleteScheduleActionConfig: ScheduleAction<DeleteScheduleResponse> = {
+  id: 'delete',
+  label: 'Delete',
+  subtitle: 'Delete this schedule permanently',
+  modal: {
+    banner: {
+      kind: 'warning',
+      icon: MdOutlineWarningAmber,
+      render: () =>
+        'Deletes the schedule permanently. In-progress workflow runs are not affected.',
+    },
+    withForm: false,
+  },
+  icon: MdDeleteOutline,
+  getRunnableStatus: () => 'RUNNABLE',
+  apiRoute: (params) =>
+    `/api/domains/${encodeURIComponent(params.domain)}/${encodeURIComponent(params.cluster)}/schedules/${encodeURIComponent(params.scheduleId)}`,
+  httpMethod: 'DELETE',
+  renderSuccessMessage: () => 'Schedule deleted.',
+  onSuccess: ({ queryClient, params, router }) => {
+    router.push(
+      `/domains/${encodeURIComponent(params.domain)}/${encodeURIComponent(params.cluster)}/schedules`
+    );
+    queryClient.invalidateQueries({
+      queryKey: [
+        'listSchedules',
+        { domain: params.domain, cluster: params.cluster },
+      ],
+    });
+  },
+};
+
 const scheduleActionsConfig = [
   pauseScheduleActionConfig,
   resumeScheduleActionConfig,
+  deleteScheduleActionConfig,
 ] as const;
 
 /** Discriminated union of configured actions; use at menu/selection boundaries. */
diff --git a/src/views/schedule-actions/schedule-actions-menu/__tests__/schedule-actions-menu.test.tsx b/src/views/schedule-actions/schedule-actions-menu/__tests__/schedule-actions-menu.test.tsx
@@ -41,7 +41,7 @@ describe(ScheduleActionsMenu.name, () => {
     });
 
     const menuButtons = screen.getAllByRole('button');
-    expect(menuButtons).toHaveLength(2);
+    expect(menuButtons).toHaveLength(3);
 
     expect(within(menuButtons[0]).getByText('Mock pause')).toBeInTheDocument();
     expect(
@@ -54,13 +54,20 @@ describe(ScheduleActionsMenu.name, () => {
       within(menuButtons[1]).getByText('Mock resume a schedule')
     ).toBeInTheDocument();
     expect(menuButtons[1]).not.toBeDisabled();
+
+    expect(within(menuButtons[2]).getByText('Delete')).toBeInTheDocument();
+    expect(
+      within(menuButtons[2]).getByText('Mock delete a schedule')
+    ).toBeInTheDocument();
+    expect(menuButtons[2]).not.toBeDisabled();
   });
 
   it('disables menu items and shows tooltip if they are disabled from config', async () => {
     const { user } = setup({
       actionsEnabledConfig: {
         pause: 'DISABLED_DEFAULT',
         resume: 'DISABLED_DEFAULT',
+        delete: 'DISABLED_DEFAULT',
       },
     });
 
diff --git a/src/views/schedule-actions/schedule-actions-modal-content/__tests__/schedule-actions-modal-content.test.tsx b/src/views/schedule-actions/schedule-actions-modal-content/__tests__/schedule-actions-modal-content.test.tsx
@@ -7,7 +7,6 @@ import { type PauseScheduleResponse } from '@/route-handlers/pause-schedule/paus
 import { type UnpauseScheduleResponse } from '@/route-handlers/unpause-schedule/unpause-schedule.types';
 
 import { mockScheduleActionsConfig } from '../../__fixtures__/schedule-actions-config';
-import { type ScheduleAction } from '../../schedule-actions.types';
 import ScheduleActionsModalContent from '../schedule-actions-modal-content';
 
 const mockScheduleParams = {
@@ -26,10 +25,9 @@ jest.mock('baseui/snackbar', () => ({
   }),
 }));
 
-const mockPush = jest.fn();
 jest.mock('next/navigation', () => ({
   ...jest.requireActual('next/navigation'),
-  useRouter: () => ({ push: mockPush }),
+  useRouter: () => ({ push: jest.fn() }),
 }));
 
 describe(ScheduleActionsModalContent.name, () => {
@@ -146,11 +144,9 @@ describe(ScheduleActionsModalContent.name, () => {
 
 function setup({
   error,
-  actionConfig,
   schedule = mockDescribeScheduleResponse,
 }: {
   error?: boolean;
-  actionConfig?: ScheduleAction<any, any, any>;
   schedule?: typeof mockDescribeScheduleResponse;
 }) {
   const user = userEvent.setup();
@@ -163,7 +159,7 @@ function setup({
 
   render(
     <ScheduleActionsModalContent
-      action={actionConfig ?? mockScheduleActionsConfig[0]}
+      action={mockScheduleActionsConfig[0]}
       params={{ ...mockScheduleParams }}
       schedule={schedule}
       onCloseModal={mockOnClose}
diff --git a/src/views/schedule-actions/schedule-actions-modal-content/schedule-actions-modal-content.tsx b/src/views/schedule-actions/schedule-actions-modal-content/schedule-actions-modal-content.tsx
@@ -62,17 +62,22 @@ export default function ScheduleActionsModalContent<
         cluster,
         scheduleId,
         submissionData,
-      }: ScheduleActionInput<SubmissionData>) =>
-        request(action.apiRoute({ domain, cluster, scheduleId }), {
-          method: 'POST',
+      }: ScheduleActionInput<SubmissionData>) => {
+        const httpMethod = action.httpMethod ?? 'POST';
+
+        return request(action.apiRoute({ domain, cluster, scheduleId }), {
+          method: httpMethod,
           body: JSON.stringify(submissionData ?? {}),
-        }).then((res) => res.json() as Result),
+        }).then((res) => res.json() as Result);
+      },
       onSuccess: (result, mutationParams) => {
-        queryClient.invalidateQueries({
-          queryKey: ['describeSchedule', params],
-        });
-
-        action.onSuccess?.({ queryClient, params, router });
+        if (!action.onSuccess)
+          queryClient.invalidateQueries({
+            queryKey: ['describeSchedule', params],
+          });
+        else {
+          action.onSuccess?.({ queryClient, params, router });
+        }
 
         onCloseModal();
         enqueue({
@@ -105,6 +110,9 @@ export default function ScheduleActionsModalContent<
     });
   };
 
+  const Form = action.modal.form;
+  const isSubmitDisabled = Object.keys(validationErrors).length > 0;
+
   const modalBanner = action.modal.banner ? (
     <Banner
       hierarchy={HIERARCHY.low}
@@ -118,9 +126,6 @@ export default function ScheduleActionsModalContent<
     </Banner>
   ) : null;
 
-  const Form = action.modal.form;
-  const isSubmitDisabled = Object.keys(validationErrors).length > 0;
-
   return (
     <>
       <styled.ModalHeader>{`${action.label} schedule`}</styled.ModalHeader>
diff --git a/src/views/schedule-actions/schedule-actions.types.ts b/src/views/schedule-actions/schedule-actions.types.ts
@@ -86,6 +86,8 @@ export type ScheduleActionModalForm<FormData, SubmissionData> =
       transformFormDataToSubmission?: undefined;
     };
 
+export type ScheduleActionHttpMethod = 'POST' | 'PUT' | 'DELETE';
+
 export type ScheduleAction<
   Result,
   FormData = undefined,
@@ -102,6 +104,7 @@ export type ScheduleAction<
     schedule: DescribeScheduleResponse
   ) => ScheduleActionRunnableStatus;
   apiRoute: (params: ScheduleActionInputParams) => string;
+  httpMethod?: ScheduleActionHttpMethod;
   getConfirmSubmissionData?: () => SubmissionData;
   renderSuccessMessage: (
     props: ScheduleActionSuccessMessageProps<SubmissionData, Result>

Original file line number	Diff line number	Diff line change
`@@ -4,16 +4,19 @@ export const AUTHORIZED_SCHEDULE_ACTIONS_CONFIG: ScheduleActionsEnabledConfig =`
`4`	`4`	`{`
`5`	`5`	`pause: 'ENABLED',`
`6`	`6`	`resume: 'ENABLED',`
	`7`	`+ delete: 'ENABLED',`
`7`	`8`	`};`
`8`	`9`
`9`	`10`	`export const UNAUTHORIZED_SCHEDULE_ACTIONS_CONFIG: ScheduleActionsEnabledConfig =`
`10`	`11`	`{`
`11`	`12`	`pause: 'DISABLED_UNAUTHORIZED',`
`12`	`13`	`resume: 'DISABLED_UNAUTHORIZED',`
	`14`	`+ delete: 'DISABLED_UNAUTHORIZED',`
`13`	`15`	`};`
`14`	`16`
`15`	`17`	`export const DEFAULT_DISABLED_SCHEDULE_ACTIONS_CONFIG: ScheduleActionsEnabledConfig =`
`16`	`18`	`{`
`17`	`19`	`pause: 'DISABLED_DEFAULT',`
`18`	`20`	`resume: 'DISABLED_DEFAULT',`
	`21`	`+ delete: 'DISABLED_DEFAULT',`
`19`	`22`	`};`
Original file line number	Diff line number	Diff line change
`@@ -152,6 +152,7 @@ function setup({`
`152`	`152`	`{`
`153`	`153`	`pause: 'ENABLED',`
`154`	`154`	`resume: 'ENABLED',`
	`155`	`+ delete: 'ENABLED',`
`155`	`156`	`},`
`156`	`157`	`{ status: 200 }`
`157`	`158`	`);`