Skip to content

Commit 6b3c6c8

Browse files
committed
Merge branch 'feat/schedule-actions-modal' into feat/schedule-actions-mount
Bring in modal layout fix: move banner above error.
2 parents 7e00a76 + ca1c4c5 commit 6b3c6c8

2 files changed

Lines changed: 2 additions & 9 deletions

File tree

src/views/schedule-actions/schedule-actions-modal-content/schedule-actions-modal-content.styles.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,6 @@ export const styled = {
1515
overflowY: 'auto',
1616
maxHeight: '70vh',
1717
})),
18-
ContextBanner: createStyled(
19-
'div',
20-
({ $theme }: { $theme: Theme }): StyleObject => ({
21-
marginBottom: $theme.sizing.scale500,
22-
})
23-
),
2418
ModalBodyContent: createStyled(
2519
'div',
2620
({ $theme }: { $theme: Theme }): StyleObject => ({
@@ -48,6 +42,7 @@ export const overrides = {
4842
banner: {
4943
Root: {
5044
style: {
45+
marginTop: 0,
5146
marginLeft: 0,
5247
marginRight: 0,
5348
},

src/views/schedule-actions/schedule-actions-modal-content/schedule-actions-modal-content.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,7 @@ export default function ScheduleActionsModalContent<
124124
<styled.ModalHeader>{`${action.label} schedule`}</styled.ModalHeader>
125125
<form onSubmit={handleSubmit(onSubmit)}>
126126
<styled.ModalBody>
127+
{modalBanner}
127128
{error && (
128129
<div ref={errorAlertRef} role="alert">
129130
<Banner
@@ -138,9 +139,6 @@ export default function ScheduleActionsModalContent<
138139
</Banner>
139140
</div>
140141
)}
141-
{modalBanner ? (
142-
<styled.ContextBanner>{modalBanner}</styled.ContextBanner>
143-
) : null}
144142
<styled.ModalBodyContent>
145143
{action.modal.withForm && Form && (
146144
<Form

0 commit comments

Comments
 (0)