From 342d6baf4f4c64715d59c5d6cf0bc4b3bcce1f17 Mon Sep 17 00:00:00 2001 From: taylan isikdemir Date: Mon, 2 Dec 2024 11:43:13 -0800 Subject: [PATCH 01/10] Switch to codecov action v5+ for tokenless uploads --- .github/workflows/codecov.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/codecov.yml b/.github/workflows/codecov.yml index cb3785b9782..efc3b7e4e68 100644 --- a/.github/workflows/codecov.yml +++ b/.github/workflows/codecov.yml @@ -23,9 +23,8 @@ jobs: run: make cover_profile - name: Upload coverage reports to Codecov - uses: codecov/codecov-action@v4.5.0 # https://github.com/codecov/codecov-action + uses: codecov/codecov-action@v5.0.7 # https://github.com/codecov/codecov-action with: file: .build/coverage/unit_cover.out exclude: ./ - token: ${{ secrets.CODECOV_TOKEN }} slug: cadence-workflow/cadence From 977cc1509741e70b6a32478296dc5e13cade9beb Mon Sep 17 00:00:00 2001 From: taylan isikdemir Date: Fri, 6 Dec 2024 10:58:45 -0800 Subject: [PATCH 02/10] try again --- .github/workflows/codecov.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/codecov.yml b/.github/workflows/codecov.yml index efc3b7e4e68..cb3785b9782 100644 --- a/.github/workflows/codecov.yml +++ b/.github/workflows/codecov.yml @@ -23,8 +23,9 @@ jobs: run: make cover_profile - name: Upload coverage reports to Codecov - uses: codecov/codecov-action@v5.0.7 # https://github.com/codecov/codecov-action + uses: codecov/codecov-action@v4.5.0 # https://github.com/codecov/codecov-action with: file: .build/coverage/unit_cover.out exclude: ./ + token: ${{ secrets.CODECOV_TOKEN }} slug: cadence-workflow/cadence From a09076d51fa46c97945aa199f6dd60bb50a4ccec Mon Sep 17 00:00:00 2001 From: taylan isikdemir Date: Wed, 8 Jan 2025 14:09:24 -0800 Subject: [PATCH 03/10] try with action@5.0.7 and no token passed. disabled global token requirement on admin panel --- .github/workflows/codecov.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/codecov.yml b/.github/workflows/codecov.yml index cb3785b9782..4289b13cce5 100644 --- a/.github/workflows/codecov.yml +++ b/.github/workflows/codecov.yml @@ -23,9 +23,9 @@ jobs: run: make cover_profile - name: Upload coverage reports to Codecov - uses: codecov/codecov-action@v4.5.0 # https://github.com/codecov/codecov-action + uses: codecov/codecov-action@v5.0.7 # https://github.com/codecov/codecov-action with: file: .build/coverage/unit_cover.out exclude: ./ - token: ${{ secrets.CODECOV_TOKEN }} + # token: ${{ secrets.CODECOV_TOKEN }} slug: cadence-workflow/cadence From 71042c2cf22b684421cb985cfa19c0817166a265 Mon Sep 17 00:00:00 2001 From: taylan isikdemir Date: Wed, 8 Jan 2025 15:20:22 -0800 Subject: [PATCH 04/10] try with an invalid token set --- .github/workflows/codecov.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/codecov.yml b/.github/workflows/codecov.yml index 4289b13cce5..5dbe9c3eccc 100644 --- a/.github/workflows/codecov.yml +++ b/.github/workflows/codecov.yml @@ -25,7 +25,8 @@ jobs: - name: Upload coverage reports to Codecov uses: codecov/codecov-action@v5.0.7 # https://github.com/codecov/codecov-action with: - file: .build/coverage/unit_cover.out + files: .build/coverage/unit_cover.out exclude: ./ # token: ${{ secrets.CODECOV_TOKEN }} + token: not-actual-token slug: cadence-workflow/cadence From b00a177b336f9e7008d14f3bea7819cc3a7c57ab Mon Sep 17 00:00:00 2001 From: taylan isikdemir Date: Thu, 9 Jan 2025 10:04:41 -0800 Subject: [PATCH 05/10] test docker publish action upgrades --- .github/workflows/docker_publish.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/docker_publish.yml b/.github/workflows/docker_publish.yml index 56a456b416d..2d539b910de 100644 --- a/.github/workflows/docker_publish.yml +++ b/.github/workflows/docker_publish.yml @@ -82,7 +82,7 @@ jobs: if: ${{ needs.meta.outputs.push_enabled == 'true' }} uses: docker/login-action@v3 with: - username: ${{ secrets.CADENCE_SERVER_DOCKERHUB_USERNAME }} + username: ${{ vars.CADENCE_SERVER_DOCKERHUB_USERNAME }} password: ${{ secrets.CADENCE_SERVER_DOCKERHUB_TOKEN }} - name: Set up QEMU uses: docker/setup-qemu-action@v3 From 15fe8d947b60a96c449177be760d2cb48a15f919 Mon Sep 17 00:00:00 2001 From: taylan isikdemir Date: Thu, 9 Jan 2025 10:06:42 -0800 Subject: [PATCH 06/10] fix format --- .github/workflows/docker_publish.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/docker_publish.yml b/.github/workflows/docker_publish.yml index 2d539b910de..23862708d2c 100644 --- a/.github/workflows/docker_publish.yml +++ b/.github/workflows/docker_publish.yml @@ -50,6 +50,7 @@ jobs: - name: Checkout uses: actions/checkout@v4 - name: Login to Docker Hub +<<<<<<< HEAD if: ${{ needs.meta.outputs.push_enabled == 'true' }} uses: docker/login-action@v3 with: @@ -80,6 +81,8 @@ jobs: uses: actions/checkout@v4 - name: Login to Docker Hub if: ${{ needs.meta.outputs.push_enabled == 'true' }} +======= +>>>>>>> 5a55c4b5c (fix format) uses: docker/login-action@v3 with: username: ${{ vars.CADENCE_SERVER_DOCKERHUB_USERNAME }} From a7c806e940cfc35a17ac8fefe035bb142c920341 Mon Sep 17 00:00:00 2001 From: taylan isikdemir Date: Thu, 9 Jan 2025 10:09:15 -0800 Subject: [PATCH 07/10] use username to secrets --- .github/workflows/docker_publish.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/docker_publish.yml b/.github/workflows/docker_publish.yml index 23862708d2c..8d91f73bea9 100644 --- a/.github/workflows/docker_publish.yml +++ b/.github/workflows/docker_publish.yml @@ -85,7 +85,7 @@ jobs: >>>>>>> 5a55c4b5c (fix format) uses: docker/login-action@v3 with: - username: ${{ vars.CADENCE_SERVER_DOCKERHUB_USERNAME }} + username: ${{ secrets.CADENCE_SERVER_DOCKERHUB_USERNAME }} password: ${{ secrets.CADENCE_SERVER_DOCKERHUB_TOKEN }} - name: Set up QEMU uses: docker/setup-qemu-action@v3 From 911b7a897fa95630ee81927d730f289f0e7bba1f Mon Sep 17 00:00:00 2001 From: taylan isikdemir Date: Thu, 9 Jan 2025 10:14:32 -0800 Subject: [PATCH 08/10] try without docker login. no push anyway --- .github/workflows/docker_publish.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/workflows/docker_publish.yml b/.github/workflows/docker_publish.yml index 8d91f73bea9..6337a89d843 100644 --- a/.github/workflows/docker_publish.yml +++ b/.github/workflows/docker_publish.yml @@ -49,6 +49,7 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4 +<<<<<<< HEAD - name: Login to Docker Hub <<<<<<< HEAD if: ${{ needs.meta.outputs.push_enabled == 'true' }} @@ -56,6 +57,15 @@ jobs: with: username: ${{ secrets.CADENCE_SERVER_DOCKERHUB_USERNAME }} password: ${{ secrets.CADENCE_SERVER_DOCKERHUB_TOKEN }} +======= + + # secrets are not available for forks so cannot test this on a PR. Push is disabled so don't need it anyway + # - name: Login to Docker Hub + # uses: docker/login-action@v3 + # with: + # username: ${{ secrets.CADENCE_SERVER_DOCKERHUB_USERNAME }} + # password: ${{ secrets.CADENCE_SERVER_DOCKERHUB_TOKEN }} +>>>>>>> 6ffd2351b (try without docker login. no push anyway) - name: Set up QEMU uses: docker/setup-qemu-action@v3 - name: Set up Docker Buildx From 79b6093fe2571791ec204fda5f59affdc51580b9 Mon Sep 17 00:00:00 2001 From: taylan isikdemir Date: Thu, 9 Jan 2025 10:40:44 -0800 Subject: [PATCH 09/10] test docker publish with final structure without pushing --- .github/workflows/docker_publish.yml | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/.github/workflows/docker_publish.yml b/.github/workflows/docker_publish.yml index 6337a89d843..56a456b416d 100644 --- a/.github/workflows/docker_publish.yml +++ b/.github/workflows/docker_publish.yml @@ -49,23 +49,12 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4 -<<<<<<< HEAD - name: Login to Docker Hub -<<<<<<< HEAD if: ${{ needs.meta.outputs.push_enabled == 'true' }} uses: docker/login-action@v3 with: username: ${{ secrets.CADENCE_SERVER_DOCKERHUB_USERNAME }} password: ${{ secrets.CADENCE_SERVER_DOCKERHUB_TOKEN }} -======= - - # secrets are not available for forks so cannot test this on a PR. Push is disabled so don't need it anyway - # - name: Login to Docker Hub - # uses: docker/login-action@v3 - # with: - # username: ${{ secrets.CADENCE_SERVER_DOCKERHUB_USERNAME }} - # password: ${{ secrets.CADENCE_SERVER_DOCKERHUB_TOKEN }} ->>>>>>> 6ffd2351b (try without docker login. no push anyway) - name: Set up QEMU uses: docker/setup-qemu-action@v3 - name: Set up Docker Buildx @@ -91,8 +80,6 @@ jobs: uses: actions/checkout@v4 - name: Login to Docker Hub if: ${{ needs.meta.outputs.push_enabled == 'true' }} -======= ->>>>>>> 5a55c4b5c (fix format) uses: docker/login-action@v3 with: username: ${{ secrets.CADENCE_SERVER_DOCKERHUB_USERNAME }} From f5ede162aec3b20bb03b5d35348573999d44b25d Mon Sep 17 00:00:00 2001 From: taylan isikdemir Date: Sun, 12 Jan 2025 15:42:14 -0800 Subject: [PATCH 10/10] try without token --- .github/workflows/codecov.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/codecov.yml b/.github/workflows/codecov.yml index 5dbe9c3eccc..cff7d1aa3df 100644 --- a/.github/workflows/codecov.yml +++ b/.github/workflows/codecov.yml @@ -28,5 +28,5 @@ jobs: files: .build/coverage/unit_cover.out exclude: ./ # token: ${{ secrets.CODECOV_TOKEN }} - token: not-actual-token + # token: not-actual-token slug: cadence-workflow/cadence