Tuning grafana client queries to have domain as a filter #6856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishwa-uber
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Groxx
reviewed
May 2, 2025
| "editorMode": "code", | ||
| "expr": "avg by(operation) (rate(cadence_client_errors[$__rate_interval]))", | ||
| "editorMode": "builder", | ||
| "expr": "avg by(operation) (rate(cadence_client_errors{domain!~\"$domain\"}[$__rate_interval]))", |
There was a problem hiding this comment.
"average for all other domains" (!~) seems backwards?
Groxx
reviewed
May 2, 2025
| "options": { | ||
| "mode": "exclude", | ||
| "names": [ | ||
| "HistoryClientRespondDecisionTaskCompleted" |
There was a problem hiding this comment.
it's often worth excluding poll-responses since they generally don't have issues like this and they just retry. but an exclude by regex for respond(decision|activity) is probably best in that case.
Groxx
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tuning the queries for client - adding domain filters for all prometheus queries
Why?
queries need to incorporate the filters from above
How did you test it?
locally
Potential risks
low