wip

Author: jbreue16

doc/interface/sensitivities.rst

@@ -39,7 +39,7 @@ Group /input/sensitivity/param_XXX
 
 ``SENS_NAME``
 
-   Name of the parameter (Note that ``PAR_RADIUS`` and ``PAR_CORE_RADIUS`` sensitivities are only available for Finite Volume discretization)
+   Name of the parameter (Note that ``PAR_RADIUS`` and ``PAR_CORERADIUS`` sensitivities are only available for Finite Volume discretization)
 
    ================  ===========================
    **Type:** string  **Length:** :math:`\geq 1`

src/libcadet/model/parts/ParticleDiffusionOperatorDG.cpp

@@ -635,7 +635,7 @@ namespace parts
 
 		//if (_axiallyConstantParTypeVolFrac)
 		//{
-		//	// Register only the f_Irst _nParType items
+		//	// Register only the first _nParType items
 		//	for (unsigned int i = 0; i < _nParType; ++i)
 		//		parameters[makeParamId(hashString("PAR_TYPE_VOLFRAC"), unitOpIdx, CompIndep, i, BoundStateIndep, ReactionIndep, SectionIndep)] = &_parTypeVolFrac[i];
 		//}
@@ -909,7 +909,7 @@ namespace parts
 		// Sort in descending order
 		std::sort(orderedInterfaces.begin(), orderedInterfaces.end(), std::greater<active>());
 
-		// Force f_Irst and last element to be 1.0 and 0.0, respectively
+		// Force first and last element to be 1.0 and 0.0, respectively
 		orderedInterfaces[0] = 1.0;
 		orderedInterfaces.back() = 0.0;
 

test/GeneralRateModelDG.cpp

@@ -64,21 +64,27 @@ TEST_CASE("GRM_DG non-binding linear pulse vs analytic solution", "[GRM],[DG],[D
 //	}
 //}
 
-TEST_CASE("GRM_DG numerical Benchmark with parameter sensitivities for linear case", "[GRM],[DG],[DG1D],[Simulation],[Reference],[Sensitivity]") // todo CI flag: currently only runs locally but fails on server
+TEST_CASE("GRM_DG numerical Benchmark with parameter sensitivities for linear case", "[GRM],[DG],[DG1D],[Simulation],[Reference],[Sensitivity],[testHere]") // todo CI flag: currently only runs locally but fails on server
 {
-	const std::string& modelFilePath = std::string("/data/model_GRM_dynLin_1comp_benchmark1.json");
-	const std::string& refFilePath = std::string("/data/ref_GRM_dynLin_1comp_sensbenchmark1_cDG_P3Z8_GSM_parP3parZ1.h5");
-	const std::vector<double> absTol = { 1e-12, 1e-6, 1e-6, 1e-12 };
-	const std::vector<double> relTol = { 1.0, 1.0, 1.0, 1.0 };
+	std::string modelFilePath = std::string("/data/model_GRM_dynLin_1comp_benchmark1.json");
+	std::string refFilePath = std::string("/data/ref_GRM_dynLin_1comp_sensbenchmark1_cDG_P3Z8_GSM_parP3parZ1.h5");
+	std::vector<double> absTol = { 1e-12, 1e-6, 1e-6, 1e-12 };
+	std::vector<double> relTol = { 1.0, 1.0, 1.0, 1.0 };
 
 	cadet::test::column::DGparams disc(0, 3, 8, 3, 1);
 	cadet::test::column::testReferenceBenchmark(modelFilePath, refFilePath, "001", absTol, relTol, disc, true);
+
+	// test setting with other parameter sensitivities
+	modelFilePath = std::string("/data/model_GRM_dynLin_1comp_benchmark2.json");
+	refFilePath = std::string("/data/ref_GRM_dynLin_1comp_sensbenchmark2_cDG_P3Z8_GSM_parP3parZ1.h5");
+
+	cadet::test::column::testReferenceBenchmark(modelFilePath, refFilePath, "001", absTol, relTol, disc, true);
 }
 
 TEST_CASE("GRM_DG numerical Benchmark with parameter sensitivities for SMA LWE case", "[GRM],[DG],[DG1D],[Simulation],[Reference],[Sensitivity]") // todo CI flag: currently only runs locally but fails on server
 {
-	const std::string& modelFilePath = std::string("/data/model_GRM_reqSMA_4comp_benchmark1.json");
-	const std::string& refFilePath = std::string("/data/ref_GRM_reqSMA_4comp_sensbenchmark1_cDG_P3Z8_GSM_parP3parZ1.h5");
+	const std::string modelFilePath = std::string("/data/model_GRM_reqSMA_4comp_benchmark1.json");
+	const std::string refFilePath = std::string("/data/ref_GRM_reqSMA_4comp_sensbenchmark1_cDG_P3Z8_GSM_parP3parZ1.h5");
 	const std::vector<double> absTol = { 1e-12, 1e-12, 1e-12, 1e-12 };
 	const std::vector<double> relTol = { 1.0, 1.0, 1.0, 1.0 };