improved behaviour of stat weight preset organization

Author: cadon

ARKBreedingStats/Form1.extractor.cs

@@ -120,7 +120,7 @@ private void ShowSumOfChosenLevels()
                 var checkLowLevels = _lowestLevels.TryGetValue(species, out int[] lowSpeciesLevels);
 
                 var customStatNames = species.statNames;
-                var statWeights = breedingPlan1.StatWeighting.GetWeightingByPresetName(species.name);
+                var statWeights = breedingPlan1.StatWeighting.GetWeightingForSpecies(species);
                 if (statWeights.Item1 == null) checkLowLevels = false;
                 var analysisState = LevelStatus.Neutral;
                 var newTopStatsText = new List<string>();

ARKBreedingStats/Form1.library.cs

@@ -354,7 +354,7 @@ private void CalculateTopStats(List<Creature> creatures)
                 List<int> usedAndConsideredStatIndices = new List<int>(Stats.StatsCount);
                 int[] bestStat = new int[Stats.StatsCount];
                 int[] lowestStat = new int[Stats.StatsCount];
-                var statWeights = breedingPlan1.StatWeighting.GetWeightingByPresetName(species.name);
+                var statWeights = breedingPlan1.StatWeighting.GetWeightingForSpecies(species);
                 for (int s = 0; s < Stats.StatsCount; s++)
                 {
                     bestStat[s] = -1;

ARKBreedingStats/Utils.cs

@@ -4,6 +4,7 @@
 using System.Collections.Generic;
 using System.Drawing;
 using System.Globalization;
+using System.Linq;
 using System.Threading.Tasks;
 using System.Windows.Forms;
 using ARKBreedingStats.values;
@@ -469,7 +470,7 @@ public static Color ForeColor(Color backColor)
             return backColor.R * .3f + backColor.G * .59f + backColor.B * .11f < 110 ? Color.White : Color.Black;
         }
 
-        public static bool ShowTextInput(string text, out string input, string title = "", string preInput = "")
+        public static bool ShowTextInput(string text, out string input, string title = null, string preInput = null, params string[] autoCompleteStrings)
         {
             Form inputForm = new Form
             {
@@ -493,6 +494,14 @@ public static bool ShowTextInput(string text, out string input, string title = "
             inputForm.AcceptButton = buttonOk;
             inputForm.CancelButton = buttonCancel;
             textBox.Text = preInput;
+            if (autoCompleteStrings?.Any() == true)
+            {
+                textBox.AutoCompleteMode = AutoCompleteMode.SuggestAppend;
+                textBox.AutoCompleteSource = AutoCompleteSource.CustomSource;
+                var ac = new AutoCompleteStringCollection();
+                ac.AddRange(autoCompleteStrings);
+                textBox.AutoCompleteCustomSource = ac;
+            }
             textBox.SelectAll();
 
             input = string.Empty;

ARKBreedingStats/uiControls/StatWeighting.Designer.cs

@@ -18,11 +18,12 @@ public partial class StatWeighting : UserControl
         public event Action WeightingsChanged;
         private readonly Debouncer _valueChangedDebouncer = new Debouncer();
         private readonly ToolTip _tt = new ToolTip();
+        private const string NoPreset = "-";
+        private const string DefaultPreset = "Default";
 
         public StatWeighting()
         {
             InitializeComponent();
-            _tt.SetToolTip(groupBox1, "Increase the weights for stats that are more important to you to be high in the offspring.\nRight click for Presets.");
             _currentSpecies = null;
 
             var displayedStats = new int[]{
@@ -97,11 +98,11 @@ public double[] Weightings
             get
             {
                 double[] w = WeightValues;
-                double s = w.Sum() / Stats.StatsCount;
-                if (s > 0)
+                double sum = w.Sum() / Stats.StatsCount;
+                if (sum > 0)
                 {
                     for (int i = 0; i < Stats.StatsCount; i++)
-                        w[i] /= s;
+                        w[i] /= sum;
                 }
                 return w;
             }
@@ -157,7 +158,7 @@ public byte[] AnyOddEven
 
         private void btAllToOne_Click(object sender, EventArgs e)
         {
-            cbbPresets.SelectedIndex = 0;
+            ResetValues();
         }
 
         /// <summary>
@@ -170,7 +171,7 @@ public bool TrySetPresetBySpecies(Species species, bool useDefaultBackupIfAvaila
             if (TrySetPresetByName(species.DescriptiveName)) return true;
             if (TrySetPresetByName(species.name)) return true;
             return useDefaultBackupIfAvailable
-                   && TrySetPresetByName("Default");
+                   && TrySetPresetByName(DefaultPreset);
         }
 
         /// <summary>
@@ -201,10 +202,8 @@ private void cbbPresets_SelectedIndexChanged(object sender, EventArgs e)
         /// <returns>True if the preset was set, false if there is no preset with the given name</returns>
         private bool SelectPresetByName(string presetName)
         {
-            if (presetName == "-")
+            if (presetName == NoPreset)
             {
-                WeightValues = Enumerable.Repeat(1d, Stats.StatsCount).ToArray();
-                AnyOddEven = Enumerable.Repeat((byte)0, Stats.StatsCount).ToArray();
                 return true;
             }
             if (!_customWeightings.TryGetValue(presetName, out var weightings)) return false;
@@ -213,6 +212,15 @@ private bool SelectPresetByName(string presetName)
             return true;
         }
 
+        /// <summary>
+        /// Resets all weightings.
+        /// </summary>
+        private void ResetValues()
+        {
+            WeightValues = Enumerable.Repeat(1d, Stats.StatsCount).ToArray();
+            AnyOddEven = Enumerable.Repeat((byte)0, Stats.StatsCount).ToArray();
+        }
+
         /// <summary>
         /// Returns weightings for species. First the blueprint path is checked, then the full species name inclusive mod and variant, then only the base name.
         /// </summary>
@@ -223,14 +231,14 @@ private bool SelectPresetByName(string presetName)
             if (_customWeightings.TryGetValue(species.DescriptiveName, out weightings)) return weightings;
             if (_customWeightings.TryGetValue(species.name, out weightings)) return weightings;
             return useDefaultBackupIfAvailable
-                   && _customWeightings.TryGetValue("Default", out weightings) ? weightings : (null, null);
+                   && _customWeightings.TryGetValue(DefaultPreset, out weightings) ? weightings : (null, null);
         }
 
         public (double[], byte[]) GetWeightingByPresetName(string presetName, bool useDefaultBackupIfAvailable = true)
         {
             if (_customWeightings.TryGetValue(presetName, out var weightings)) return weightings;
             return useDefaultBackupIfAvailable
-                && _customWeightings.TryGetValue("Default", out weightings) ? weightings : (null, null);
+                && _customWeightings.TryGetValue(DefaultPreset, out weightings) ? weightings : (null, null);
         }
 
         private void btDelete_Click(object sender, EventArgs e)
@@ -250,29 +258,57 @@ private void DeletePresetByName(string presetName)
             }
         }
 
-        private void btSavePreset_Click(object sender, EventArgs e)
+        private void BtSavePreset_Click(object sender, EventArgs e)
         {
-            SavePreset(_currentSpecies.name);
+            var presetName = cbbPresets.SelectedItem.ToString();
+            if (string.IsNullOrEmpty(presetName) || presetName == NoPreset)
+                SavePresetAs(_currentSpecies?.name);
+            else _customWeightings[presetName] = (WeightValues, AnyOddEven);
         }
 
-        private void SavePreset(string presetName)
+        private void btSavePresetAs_Click(object sender, EventArgs e)
         {
-            if (Utils.ShowTextInput("Preset-Name", out presetName, "New Preset", presetName) && presetName.Length > 0)
+            var presetName = cbbPresets.SelectedItem.ToString();
+            if (string.IsNullOrEmpty(presetName) || presetName == NoPreset || presetName == DefaultPreset)
+                SavePresetAs(_currentSpecies?.name);
+            else SavePresetAs(presetName);
+        }
+
+        private void SavePresetAs(string presetName)
+        {
+            string[] suggestions;
+            if (_currentSpecies != null)
             {
-                if (_customWeightings.ContainsKey(presetName))
+                suggestions = new[]
                 {
-                    if (MessageBox.Show("Preset-Name exists already, overwrite?", "Overwrite Preset?",
+                    DefaultPreset,
+                    _currentSpecies.name,
+                    _currentSpecies.DescriptiveName,
+                    _currentSpecies.DescriptiveNameAndMod,
+                    _currentSpecies.blueprintPath
+                };
+            }
+            else
+                suggestions = new[] { DefaultPreset };
+
+
+            if (Utils.ShowTextInput("Preset Name", out var presetNameUser, "New Preset", presetName, suggestions)
+                && presetNameUser.Length > 0)
+            {
+                if (_customWeightings.ContainsKey(presetNameUser))
+                {
+                    if (MessageBox.Show("Preset name exists already, overwrite?", "Overwrite Preset?",
                             MessageBoxButtons.YesNo, MessageBoxIcon.Question) == DialogResult.Yes)
                     {
-                        _customWeightings[presetName] = (WeightValues, AnyOddEven);
+                        _customWeightings[presetNameUser] = (WeightValues, AnyOddEven);
                     }
                     else
                         return;
                 }
                 else
-                    _customWeightings.Add(presetName, (WeightValues, AnyOddEven));
+                    _customWeightings.Add(presetNameUser, (WeightValues, AnyOddEven));
                 CustomWeightings = _customWeightings;
-                TrySetPresetByName(presetName);
+                TrySetPresetByName(presetNameUser);
             }
         }
 
@@ -285,12 +321,25 @@ private void SavePreset(string presetName)
                 _customWeightings = value;
                 // clear custom presets
                 cbbPresets.Items.Clear();
-                cbbPresets.Items.Add("-");
-                cbbPresets.Items.AddRange(_customWeightings.Keys.ToArray());
+                cbbPresets.Items.Add(NoPreset);
+                cbbPresets.Items.AddRange(_customWeightings.Keys.OrderBy(s => s).ToArray());
                 cbbPresets.SelectedIndex = 0;
+                SetComboboxDropdownWidthToMaxItemWidth(cbbPresets);
             }
         }
 
+        private void SetComboboxDropdownWidthToMaxItemWidth(ComboBox cbb)
+        {
+            var g = cbb.CreateGraphics();
+            var verticalScrollBarWidth = cbb.Items.Count > cbb.MaxDropDownItems
+                    ? SystemInformation.VerticalScrollBarWidth : 0;
+
+            var maxWidth = cbb.Items.Cast<string>().Select(s => (int)g.MeasureString(s, cbb.Font).Width + verticalScrollBarWidth).Max();
+            maxWidth = Math.Min(600, maxWidth);
+            if (maxWidth > cbb.DropDownWidth)
+                cbb.DropDownWidth = maxWidth;
+        }
+
         private class TriButton : Button
         {
             private readonly ToolTip _tt;