fix: route profile image format detection through image utils

Author: TakuyaYagam1

components/images/ProfileImage.qml

@@ -2,18 +2,18 @@ pragma ComponentBehavior: Bound
 
 import QtQuick
 import Quickshell
-import Caelestia
+import Caelestia.Images
 
 Item {
     id: root
 
     property string path
-    property string _format: CUtils.imageFormat(path)
+    property string _format: IUtils.imageFormat(path)
 
-    readonly property int status: loader.item?.status ?? Image.Null // qmllint disable
+    readonly property int status: (loader.item as Image)?.status ?? Image.Null
 
     function reload(): void {
-        _format = Qt.binding(() => CUtils.imageFormat(path));
+        _format = Qt.binding(() => IUtils.imageFormat(path));
         loader.active = false;
         loader.active = true;
     }
@@ -36,6 +36,7 @@ Item {
                 return Qt.size(width * dpr, height * dpr);
             }
             asynchronous: true
+            cache: false
             playing: true
             source: Qt.resolvedUrl(root.path)
         }
@@ -46,6 +47,7 @@ Item {
 
         CachingImage {
             anchors.fill: parent
+            cache: false
             path: root.path
         }
     }

modules/dashboard/dash/User.qml

@@ -103,7 +103,7 @@ Row {
 
         Connections {
             function onAccepted(): void {
-                pfp.reload();
+                Qt.callLater(pfp.reload);
             }
 
             target: root.facePicker

plugin/src/Caelestia/Images/iutils.cpp

@@ -2,6 +2,8 @@
 
 #include "cachingimageprovider.hpp"
 
+#include <qimagereader.h>
+
 namespace caelestia::images {
 
 IUtils* IUtils::create(QQmlEngine* engine, QJSEngine* jsEngine) {
@@ -15,6 +17,10 @@ IUtils* IUtils::create(QQmlEngine* engine, QJSEngine* jsEngine) {
     return new IUtils(engine);
 }
 
+QString IUtils::imageFormat(const QString& path) {
+    return QString::fromLatin1(QImageReader::imageFormat(path));
+}
+
 QUrl IUtils::urlForPath(const QString& path, int fillMode) {
     if (path.isEmpty())
         return QUrl();

plugin/src/Caelestia/Images/iutils.hpp

@@ -14,6 +14,7 @@ class IUtils : public QObject {
 public:
     static IUtils* create(QQmlEngine* engine, QJSEngine* jsEngine);
 
+    Q_INVOKABLE static QString imageFormat(const QString& path);
     Q_INVOKABLE static QUrl urlForPath(const QString& path, int fillMode);
 
 private:

plugin/src/Caelestia/cutils.cpp

@@ -6,7 +6,6 @@
 #include <qdir.h>
 #include <qfileinfo.h>
 #include <qfuturewatcher.h>
-#include <qimagereader.h>
 #include <qloggingcategory.h>
 #include <qqmlengine.h>
 
@@ -139,17 +138,4 @@ QString CUtils::toLocalFile(const QUrl& url) const {
     return url.toLocalFile();
 }
 
-QString CUtils::imageFormat(const QUrl& url) const {
-    if (!url.isLocalFile()) {
-        qCWarning(lcCUtils) << "imageFormat: url" << url << "is not a local file";
-        return QString();
-    }
-
-    return imageFormat(url.toLocalFile());
-}
-
-QString CUtils::imageFormat(const QString& path) const {
-    return QString::fromLatin1(QImageReader::imageFormat(path));
-}
-
 } // namespace caelestia

plugin/src/Caelestia/cutils.hpp

@@ -24,8 +24,6 @@ class CUtils : public QObject {
     Q_INVOKABLE bool copyFile(const QUrl& source, const QUrl& target, bool overwrite = true) const;
     Q_INVOKABLE bool deleteFile(const QUrl& path) const;
     Q_INVOKABLE QString toLocalFile(const QUrl& url) const;
-    Q_INVOKABLE QString imageFormat(const QUrl& url) const;
-    Q_INVOKABLE QString imageFormat(const QString& path) const;
 };
 
 } // namespace caelestia