fix: use 0x31 metrics for Apex WLT8266BM bikes (#4887)

* fix: use 0x31 metrics for Apex WLT8266BM_07E2

* fix: disable WLT8266BM distance counter parser

---------

Co-authored-by: root <root@hermes.proxmox>

Author: cagnulein

src/devices/apexbike/apexbike.cpp

@@ -13,7 +13,10 @@
 using namespace std::chrono_literals;
 
 bool apexbike::usesWlt8266bmDistanceCounterMetrics(const QString &deviceName) {
-    return deviceName.startsWith(QStringLiteral("WLT8266BM_"), Qt::CaseInsensitive);
+    // WLT8266BM bikes report cadence and distance in 0x31 packets.
+    // Their 0x30 packet is a counter and must not be used as distance.
+    Q_UNUSED(deviceName);
+    return false;
 }
 
 bool apexbike::isWlt8266bmDistanceCounterMetricsPacket(const QString &deviceName, const QByteArray &newValue) {

tst/Devices/TestApexBikeParser.h

@@ -6,13 +6,11 @@
 
 #include "devices/apexbike/apexbike.h"
 
-TEST(ApexBikeWlt8266BmRegressionTest, DistanceCounterMetricsAreScopedToBluetoothNamePrefix) {
-    EXPECT_TRUE(apexbike::usesWlt8266bmDistanceCounterMetrics(QStringLiteral("WLT8266BM_025B")));
-    EXPECT_TRUE(apexbike::usesWlt8266bmDistanceCounterMetrics(QStringLiteral("wlt8266bm_025b")));
-    EXPECT_TRUE(apexbike::usesWlt8266bmDistanceCounterMetrics(QStringLiteral("WLT8266BM_0000")));
-
-    EXPECT_FALSE(apexbike::usesWlt8266bmDistanceCounterMetrics(QStringLiteral("WLT8266BM")));
-    EXPECT_FALSE(apexbike::usesWlt8266bmDistanceCounterMetrics(QStringLiteral("WLT8266BM025B")));
+TEST(ApexBikeWlt8266BmRegressionTest, DistanceCounterMetricsAreDisabledForWlt8266BmBikes) {
+    EXPECT_FALSE(apexbike::usesWlt8266bmDistanceCounterMetrics(QStringLiteral("WLT8266BM_025B")));
+    EXPECT_FALSE(apexbike::usesWlt8266bmDistanceCounterMetrics(QStringLiteral("WLT8266BM_07E2")));
+    EXPECT_FALSE(apexbike::usesWlt8266bmDistanceCounterMetrics(QStringLiteral("WLT8266BM_1234")));
+    EXPECT_FALSE(apexbike::usesWlt8266bmDistanceCounterMetrics(QStringLiteral("wlt8266bm_07e2")));
     EXPECT_FALSE(apexbike::usesWlt8266bmDistanceCounterMetrics(QStringLiteral("APEX Bike")));
 }