Extend DirCon loopback test with telemetry checks and push trigger

Author: cagnulein

.github/workflows/dircon-loopback.yml

@@ -0,0 +1,42 @@
+name: DirCon loopback integration test
+
+on:
+  pull_request:
+  push:
+  workflow_dispatch:
+
+jobs:
+  linux-dircon-loopback:
+    runs-on: ubuntu-24.04
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Install Qt dependencies
+        run: |
+          sudo apt update -y
+          sudo apt-get install -y \
+            qtbase5-dev qtchooser qt5-qmake qtbase5-dev-tools \
+            qtquickcontrols2-5-dev qtconnectivity5-dev qtpositioning5-dev \
+            libqt5bluetooth5 libqt5widgets5 libqt5positioning5 libqt5xml5 \
+            libqt5charts5-dev libqt5charts5 libqt5networkauth5-dev \
+            libqt5websockets5 libqt5websockets5-dev \
+            libqt5sql5-sqlite libqt5sql5 libqt5sql5-mysql libqt5sql5-psql \
+            libxcb-randr0-dev libxcb-xtest0-dev libxcb-xinerama0-dev \
+            libxcb-shape0-dev libxcb-xkb-dev
+
+      - name: Build qdomyos-zwift static library
+        run: |
+          cd src
+          qmake
+          make -j"$(nproc)"
+
+      - name: Build test binary
+        run: |
+          cd tst
+          qmake
+          make -j"$(nproc)"
+
+      - name: Run DirCon loopback test (fakebike server -> dircon client)
+        run: |
+          cd tst
+          ./qdomyos-zwift-tests --gtest_filter=DirconLoopbackTestSuite.*

tst/Devices/dirconloopbacktestsuite.cpp

@@ -0,0 +1,71 @@
+#include "dirconloopbacktestsuite.h"
+
+#include <QCoreApplication>
+#include <QDateTime>
+#include <QEventLoop>
+#include <QSettings>
+#include <functional>
+
+#include "Tools/testsettings.h"
+#include "devices/dircon/dirconmanager.h"
+#include "devices/dircon/wahoodirconbike.h"
+#include "devices/fakebike/fakebike.h"
+#include "qzsettings.h"
+
+namespace {
+
+bool waitForCondition(const std::function<bool()> &predicate, int timeoutMs) {
+    const QDateTime endTime = QDateTime::currentDateTime().addMSecs(timeoutMs);
+    while (QDateTime::currentDateTime() < endTime) {
+        if (predicate()) {
+            return true;
+        }
+        QCoreApplication::processEvents(QEventLoop::AllEvents, 50);
+    }
+    return predicate();
+}
+
+} // namespace
+
+void DirconLoopbackTestSuite::test_fakebike_dircon_server_accepts_wahoodirconbike_client() {
+    TestSettings testSettings(QStringLiteral("qz-test-org"), QStringLiteral("qz-test-dircon-loopback"));
+    testSettings.activate();
+
+    constexpr int kServerBasePort = 46000;
+    testSettings.qsettings.setValue(QZSettings::dircon_yes, true);
+    testSettings.qsettings.setValue(QZSettings::dircon_server_base_port, kServerBasePort);
+    testSettings.qsettings.setValue(QZSettings::dircon_id, 1);
+    testSettings.qsettings.setValue(QZSettings::virtual_device_enabled, false);
+    testSettings.qsettings.setValue(QZSettings::zwift_play_emulator, false);
+    testSettings.qsettings.setValue(QZSettings::rouvy_compatibility, false);
+
+    fakebike serverBike(true, true, true);
+    DirconManager dirconServer(&serverBike, 4, 1.0);
+
+    DirconDeviceInfo deviceInfo;
+    deviceInfo.name = QStringLiteral("Wahoo KICKR 0001");
+    deviceInfo.displayName = QStringLiteral("Wahoo KICKR 0001 (DirCon)");
+    deviceInfo.address = QStringLiteral("127.0.0.1");
+    deviceInfo.port = static_cast<quint16>(kServerBasePort);
+
+    wahoodirconbike clientBike(deviceInfo, true, true, 4, 1.0);
+
+    const bool connected = waitForCondition([&clientBike]() { return clientBike.connected(); }, 5000);
+    EXPECT_TRUE(connected) << "DirCon client failed to complete handshake against local fakebike DirCon server";
+
+    // Drive the fakebike with target power to force metric updates on the DirCon server side,
+    // then verify the client receives non-zero telemetry through notifications.
+    serverBike.changePower(180);
+
+    const bool receivedTelemetry = waitForCondition(
+        [&clientBike]() {
+            return clientBike.wattsMetric().value() > 0 &&
+                   clientBike.currentCadence().value() > 0 &&
+                   clientBike.currentSpeed().value() > 0;
+        },
+        8000);
+    EXPECT_TRUE(receivedTelemetry)
+        << "DirCon client connected but did not receive expected bike telemetry (watt/cadence/speed)";
+
+    testSettings.deactivate();
+}

tst/Devices/dirconloopbacktestsuite.h

@@ -0,0 +1,15 @@
+#ifndef DIRCONLOOPBACKTESTSUITE_H
+#define DIRCONLOOPBACKTESTSUITE_H
+
+#include "gtest/gtest.h"
+
+class DirconLoopbackTestSuite : public testing::Test {
+public:
+    void test_fakebike_dircon_server_accepts_wahoodirconbike_client();
+};
+
+TEST_F(DirconLoopbackTestSuite, FakeBikeDirconServerAcceptsWahooDirconBikeClient) {
+    this->test_fakebike_dircon_server_accepts_wahoodirconbike_client();
+}
+
+#endif // DIRCONLOOPBACKTESTSUITE_H

tst/qdomyos-zwift-tests.pro

@@ -16,6 +16,7 @@ SOURCES += \
         Devices/bluetoothdevicetestsuite.cpp \
         Devices/bluetoothsignalreceiver.cpp \
         Devices/devicediscoveryinfo.cpp \
+        Devices/dirconloopbacktestsuite.cpp \
         Devices/deviceindex.cpp \
         Devices/devicenamepatterngroup.cpp \
         Devices/devicetestdataindex.cpp \
@@ -50,6 +51,7 @@ HEADERS += \
     Devices/bluetoothdevicetestsuite.h \
     Devices/bluetoothsignalreceiver.h \
     Devices/devicediscoveryinfo.h \
+    Devices/dirconloopbacktestsuite.h \
     Devices/deviceindex.h \
     Devices/devicenamepatterngroup.h \
     Devices/devicetestdataindex.h \