Apply phase 2 behavior migration on push

Author: cagnulein

.github/workflows/settings-refactor-phase2.yml

@@ -1,50 +1,47 @@
 name: Settings refactor phase 2 migration
 
 on:
-  pull_request:
-    branches:
-      - master
-    paths:
-      - 'scripts/phase2_catalog_migration.py'
-      - '.github/workflows/settings-refactor-phase2.yml'
   push:
     branches:
       - agent/settings-refactor-phase1-safety
     paths:
       - 'scripts/phase2_catalog_migration.py'
+      - 'scripts/phase2_behavior_migration.py'
+      - 'tests/test_settings_behavior_migration.py'
       - '.github/workflows/settings-refactor-phase2.yml'
   workflow_dispatch:
 
 permissions:
   contents: write
 
 jobs:
-  migrate-catalog:
-    if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository
+  migrate:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
         with:
-          ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.ref || github.ref_name }}
+          ref: agent/settings-refactor-phase1-safety
           fetch-depth: 1
       - uses: actions/setup-python@v5
         with:
           python-version: '3.11'
-      - name: Complete catalog coverage
-        run: python3 scripts/phase2_catalog_migration.py
-      - name: Validate migrated catalog
+      - name: Apply Phase 2 migrations
+        run: |
+          python3 scripts/phase2_catalog_migration.py
+          python3 scripts/phase2_behavior_migration.py
+      - name: Validate Phase 2 result
         run: |
-          python3 -m unittest tests/test_settings_audit.py
+          python3 -m unittest tests/test_settings_audit.py tests/test_settings_behavior_migration.py
           python3 scripts/settings_audit.py --report settings-audit.json
-      - name: Commit catalog migration
+      - name: Commit Phase 2 migrations
         shell: bash
         run: |
-          if git diff --quiet -- src/settings-catalog.json; then
-            echo 'Catalog is already migrated.'
+          if git diff --quiet -- src/settings-catalog.json src/settings.qml; then
+            echo 'Phase 2 migrations are already applied.'
             exit 0
           fi
           git config user.name 'github-actions[bot]'
           git config user.email '41898282+github-actions[bot]@users.noreply.github.com'
-          git add src/settings-catalog.json
-          git commit -m 'Complete settings catalog coverage for phase 2'
-          git push origin HEAD:${{ github.event_name == 'pull_request' && github.event.pull_request.head.ref || github.ref_name }}
+          git add src/settings-catalog.json src/settings.qml
+          git commit -m 'Apply settings refactor phase 2 migrations'
+          git push origin HEAD:agent/settings-refactor-phase1-safety